Skip to content

Issack/5 19 pr comments with performance mark #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Parent: Addressing PR comments 2025-MAY
wants to merge 1 commit into
base: issack/5-19-pr-comments
Choose a base branch
from
Draft

Issack/5 19 pr comments with performance mark #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions experimental/responsive-design/dist/app.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions experimental/responsive-design/src/lib/components/app-ribbon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,15 @@ export class AppRibbon extends LightDOMLitElement {
this.buttons = ribbonButtons;
this.visibleButtons = this.buttons;
this._resizeObserver = new ResizeObserver((entries) => {
performance.mark("AppRibbon-resize-start");
for (const entry of entries) {
if (entry.contentBoxSize && entry.contentBoxSize[0])
this._updateVisibleButtons(entry.contentBoxSize[0].inlineSize);
else
this._updateVisibleButtons(entry.contentRect.width);
}
performance.mark("AppRibbon-resize-end");
performance.measure("AppRibbon-resize", "AppRibbon-resize-start", "AppRibbon-resize-end");
});
}

Expand All @@ -35,6 +38,7 @@ export class AppRibbon extends LightDOMLitElement {
}

_updateVisibleButtons(width) {
performance.mark("AppRibbon-updateVisibleButtons-start");
const breakpoints = [
{ minWidth: 1134, buttons: 12 },
{ minWidth: 1069, buttons: 11 },
Expand All @@ -53,6 +57,8 @@ export class AppRibbon extends LightDOMLitElement {
const breakpoint = breakpoints.find((bp) => width >= bp.minWidth);
this.visibleButtons = breakpoint ? this.buttons.slice(0, breakpoint.buttons) : this.buttons.slice(0, 2);
this.requestUpdate();
performance.mark("AppRibbon-updateVisibleButtons-end");
performance.measure("AppRibbon-updateVisibleButtons", "AppRibbon-updateVisibleButtons-start", "AppRibbon-updateVisibleButtons-end");
}

_getVisibleButtonsTemplate() {
Expand Down
6 changes: 6 additions & 0 deletions experimental/responsive-design/src/lib/components/information-window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ class InformationWindow extends LitElement {

// ResizeObserver is used primarily to exercise this API as part of the benchmark.
this._resizeObserver = new ResizeObserver((entries) => {
performance.mark("InformationWindow-resize-start");
for (const entry of entries) {
const height = entry.contentBoxSize && entry.contentBoxSize[0] ? entry.contentBoxSize[0].blockSize : entry.contentRect.height;
this._isChatExpanded = height > 350;
this._currentIndex = 0;
this.updateCarousel();
}
performance.mark("InformationWindow-resize-end");
performance.measure("InformationWindow-resize", "InformationWindow-resize-start", "InformationWindow-resize-end");
});
}

Expand Down Expand Up @@ -66,11 +69,14 @@ class InformationWindow extends LitElement {
}

updateCarousel() {
performance.mark("InformationWindow-updateCarousel-start");
const cardRow = this.shadowRoot.querySelector(".card-row");
if (cardRow)
cardRow.style.transform = `translateX(-${this._currentIndex * 100}%)`;

this.requestUpdate();
performance.mark("InformationWindow-updateCarousel-end");
performance.measure("InformationWindow-updateCarousel", "InformationWindow-updateCarousel-start", "InformationWindow-updateCarousel-end");
}

_getExpandedTemplate() {
Expand Down
3 changes: 3 additions & 0 deletions experimental/responsive-design/src/lib/components/recipe-carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,15 @@ class RecipeCarousel extends LightDOMLitElement {
this._carouselWidth = 0;
// ResizeObserver is used primarily to exercise this API as part of the benchmark.
this._resizeObserver = new ResizeObserver((entries) => {
performance.mark("RecipeCarousel-resize-start");
for (const entry of entries) {
if (entry.contentBoxSize && entry.contentBoxSize[0])
this._carouselWidth = entry.contentBoxSize[0].inlineSize;
else
this._carouselWidth = entry.contentRect.width;
}
performance.mark("RecipeCarousel-resize-end");
performance.measure("RecipeCarousel-resize", "RecipeCarousel-resize-start", "RecipeCarousel-resize-end");
});
}

Expand Down
77 changes: 72 additions & 5 deletions resources/tests.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,78 +1122,145 @@ Suites.push({
(await page.waitForElement("#content-iframe")).focus();
},
tests: [
// Do we need to call layout, RAF instead?
new BenchmarkTestStep("LoadChatAndExpandRecipes", async (page) => {
performance.mark("LoadChatAndExpandRecipes-start");

const iframeElement = page.querySelector("#content-iframe", [], true);

// Resume previous chat
performance.mark("LoadChatAndExpandRecipes-resumeChat-start");
const resumePreviousChatBtn = iframeElement.querySelectorInShadowRoot("#resume-previous-chat-btn", ["cooking-app", "chat-window"]);
resumePreviousChatBtn.click();
page.layout();
performance.mark("LoadChatAndExpandRecipes-resumeChat-end");
performance.measure("LoadChatAndExpandRecipes-resumeChat", "LoadChatAndExpandRecipes-resumeChat-start", "LoadChatAndExpandRecipes-resumeChat-end");

// Navigate through the restaurants
performance.mark("LoadChatAndExpandRecipes-navigateRestaurants-start");
const nextRestaurantBtn = iframeElement.querySelectorInShadowRoot("#next-restaurant-btn", ["cooking-app", "information-window"]);
const restaurantCards = iframeElement.querySelectorAllInShadowRoot("restaurant-card", ["cooking-app", "information-window"]);
const numOfRestaurantCards = restaurantCards.length - 1; // since 1 is already visible
for (let i = 0; i < numOfRestaurantCards; i++) {
performance.mark(`LoadChatAndExpandRecipes-restaurant-${i}-start`);
nextRestaurantBtn.click();
page.layout();
performance.mark(`LoadChatAndExpandRecipes-restaurant-${i}-end`);
performance.measure(`LoadChatAndExpandRecipes-restaurant-${i}`, `LoadChatAndExpandRecipes-restaurant-${i}-start`, `LoadChatAndExpandRecipes-restaurant-${i}-end`);
}
performance.mark("LoadChatAndExpandRecipes-navigateRestaurants-end");
performance.measure("LoadChatAndExpandRecipes-navigateRestaurants", "LoadChatAndExpandRecipes-navigateRestaurants-start", "LoadChatAndExpandRecipes-navigateRestaurants-end");

// Expand recipes
performance.mark("LoadChatAndExpandRecipes-expandRecipes-start");
const showMoreBtn = iframeElement.querySelectorAllInShadowRoot(".show-more-btn", ["cooking-app", "main-content", "recipe-grid"]);
showMoreBtn.forEach((btn) => {
showMoreBtn.forEach((btn, idx) => {
performance.mark(`LoadChatAndExpandRecipes-expandRecipe-${idx}-start`);
btn.click();
page.layout();
performance.mark(`LoadChatAndExpandRecipes-expandRecipe-${idx}-end`);
performance.measure(`LoadChatAndExpandRecipes-expandRecipe-${idx}`, `LoadChatAndExpandRecipes-expandRecipe-${idx}-start`, `LoadChatAndExpandRecipes-expandRecipe-${idx}-end`);
});
performance.mark("LoadChatAndExpandRecipes-expandRecipes-end");
performance.measure("LoadChatAndExpandRecipes-expandRecipes", "LoadChatAndExpandRecipes-expandRecipes-start", "LoadChatAndExpandRecipes-expandRecipes-end");

performance.mark("LoadChatAndExpandRecipes-end");
performance.measure("LoadChatAndExpandRecipes-total", "LoadChatAndExpandRecipes-start", "LoadChatAndExpandRecipes-end");
}),
new BenchmarkTestStep("ReduceWidthIn5Steps", async (page) => {
performance.mark("ReduceWidthIn5Steps-start");

const iframeElement = page.querySelector("#content-iframe");
const widths = [768, 704, 640, 560, 480];

widths.forEach((width) => {
widths.forEach((width, idx) => {
performance.mark(`ReduceWidthIn5Steps-step-${idx}-start`);
iframeElement.setWidth(`${width}px`);
page.layout();
performance.mark(`ReduceWidthIn5Steps-step-${idx}-end`);
performance.measure(`ReduceWidthIn5Steps-step-${idx}`, `ReduceWidthIn5Steps-step-${idx}-start`, `ReduceWidthIn5Steps-step-${idx}-end`);
});

performance.mark("ReduceWidthIn5Steps-end");
performance.measure("ReduceWidthIn5Steps-total", "ReduceWidthIn5Steps-start", "ReduceWidthIn5Steps-end");
}),
new BenchmarkTestStep("ScrollToChatAndSendMessages", async (page) => {
performance.mark("ScrollToChatAndSendMessages-start");

const iframeElement = page.querySelector("#content-iframe", [], true);

// Navigate through the carousel items
performance.mark("ScrollToChatAndSendMessages-navigateCarousel-start");
const nextItemBtn = iframeElement.querySelectorInShadowRoot("#next-item-carousel-btn", ["cooking-app", "main-content", "recipe-carousel"]);
const recipeCarouselItems = iframeElement.querySelectorAllInShadowRoot(".carousel-item", ["cooking-app", "main-content", "recipe-carousel"]);
const numOfCarouselItems = recipeCarouselItems.length - 3; // since 3 are already visible
for (let i = 0; i < numOfCarouselItems; i++) {
performance.mark(`ScrollToChatAndSendMessages-carousel-${i}-start`);
nextItemBtn.click();
page.layout();
performance.mark(`ScrollToChatAndSendMessages-carousel-${i}-end`);
performance.measure(`ScrollToChatAndSendMessages-carousel-${i}`, `ScrollToChatAndSendMessages-carousel-${i}-start`, `ScrollToChatAndSendMessages-carousel-${i}-end`);
}
performance.mark("ScrollToChatAndSendMessages-navigateCarousel-end");
performance.measure("ScrollToChatAndSendMessages-navigateCarousel", "ScrollToChatAndSendMessages-navigateCarousel-start", "ScrollToChatAndSendMessages-navigateCarousel-end");

// Collapse recipes
performance.mark("ScrollToChatAndSendMessages-collapseRecipes-start");
const showMoreBtn = iframeElement.querySelectorAllInShadowRoot(".show-more-btn", ["cooking-app", "main-content", "recipe-grid"]);
showMoreBtn.forEach((btn) => {
showMoreBtn.forEach((btn, idx) => {
performance.mark(`ScrollToChatAndSendMessages-collapse-${idx}-start`);
btn.click();
page.layout();
performance.mark(`ScrollToChatAndSendMessages-collapse-${idx}-end`);
performance.measure(`ScrollToChatAndSendMessages-collapse-${idx}`, `ScrollToChatAndSendMessages-collapse-${idx}-start`, `ScrollToChatAndSendMessages-collapse-${idx}-end`);
});
performance.mark("ScrollToChatAndSendMessages-collapseRecipes-end");
performance.measure("ScrollToChatAndSendMessages-collapseRecipes", "ScrollToChatAndSendMessages-collapseRecipes-start", "ScrollToChatAndSendMessages-collapseRecipes-end");

// Scroll to chat
performance.mark("ScrollToChatAndSendMessages-scrollToChat-start");
const element = iframeElement.querySelectorInShadowRoot("#chat-window", ["cooking-app", "chat-window"]);
element.scrollIntoView({ behavior: "instant" });
page.layout();
performance.mark("ScrollToChatAndSendMessages-scrollToChat-end");
performance.measure("ScrollToChatAndSendMessages-scrollToChat", "ScrollToChatAndSendMessages-scrollToChat-start", "ScrollToChatAndSendMessages-scrollToChat-end");

// Send messages
performance.mark("ScrollToChatAndSendMessages-sendMessages-start");
const messagesToBeSent = ["Please generate an image of Tomato Soup.", "Try again, but make the soup look thicker.", "Try again, but make the soup served in a rustic bowl and include a sprinkle of fresh herbs on top."];

const chatInput = iframeElement.querySelectorInShadowRoot("#chat-input", ["cooking-app", "chat-window"]);
messagesToBeSent.forEach((message) => {
messagesToBeSent.forEach((message, idx) => {
performance.mark(`ScrollToChatAndSendMessages-message-${idx}-start`);
chatInput.setValue(message);
chatInput.dispatchEvent("input");
chatInput.enter("keydown");
page.layout();
performance.mark(`ScrollToChatAndSendMessages-message-${idx}-end`);
performance.measure(`ScrollToChatAndSendMessages-message-${idx}`, `ScrollToChatAndSendMessages-message-${idx}-start`, `ScrollToChatAndSendMessages-message-${idx}-end`);
});
performance.mark("ScrollToChatAndSendMessages-sendMessages-end");
performance.measure("ScrollToChatAndSendMessages-sendMessages", "ScrollToChatAndSendMessages-sendMessages-start", "ScrollToChatAndSendMessages-sendMessages-end");

performance.mark("ScrollToChatAndSendMessages-end");
performance.measure("ScrollToChatAndSendMessages-total", "ScrollToChatAndSendMessages-start", "ScrollToChatAndSendMessages-end");
}),
new BenchmarkTestStep("IncreaseWidthIn5Steps", async (page) => {
performance.mark("IncreaseWidthIn5Steps-start");

const iframeElement = page.querySelector("#content-iframe");
const widths = [560, 640, 704, 768, 800];

widths.forEach((width) => {
widths.forEach((width, idx) => {
performance.mark(`IncreaseWidthIn5Steps-step-${idx}-start`);
iframeElement.setWidth(`${width}px`);
page.layout();
performance.mark(`IncreaseWidthIn5Steps-step-${idx}-end`);
performance.measure(`IncreaseWidthIn5Steps-step-${idx}`, `IncreaseWidthIn5Steps-step-${idx}-start`, `IncreaseWidthIn5Steps-step-${idx}-end`);
});

performance.mark("IncreaseWidthIn5Steps-end");
performance.measure("IncreaseWidthIn5Steps-total", "IncreaseWidthIn5Steps-start", "IncreaseWidthIn5Steps-end");
}),
],
});
Expand Down