Addressing PR comments 2025-MAY #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… design directory
…mationWindow, and RecipeCarousel
…implify resize logic
…and package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
experimental/responsive-designproject, focusing on configuration cleanup, dependency updates, and improved handling of responsive design. Key changes include the removal of unused configuration files, updates to dependencies, enhancements to responsive behavior usingResizeObserver, and minor adjustments to Tailwind CSS class ordering for consistency.Configuration and Dependency Updates:
.prettierignore,.prettierrc, andeslint.config.jsfiles from theexperimental/responsive-designdirectory, consolidating linting and formatting configurations at the project root. ([[1]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-aecd0b43a340ddd97e0e9044cbba869a975da74650b2a410e443b000d67959e8L1-L4),[[2]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-142726b2e57a75f4be0c8e61c1b6732a60d00987f66c04f6f8a52f5ffe6e929eL1-L13),[[3]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-60381a625850a716bd6bb57dcad876fd2ff570a5980d986c35ed454ab83add8aL1-L74))package.jsonto increase the minimum required Node.js version to22.0.0, updated dependencies such aslitto^3.3.0, and removed unused dependencies likeeslintandprettier. ([[1]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-5cc6559cbc236c2931f2a2c649b3a48dacde6c91c105ac1fb92dd4f2f9981944L7-R12),[[2]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-5cc6559cbc236c2931f2a2c649b3a48dacde6c91c105ac1fb92dd4f2f9981944L21-R38))Build and Output Directory Updates:
rollup.config.jsto dynamically set the output directory based on the build environment (build-devfor development,distfor production). Added logic to clean the output directory before production builds. ([[1]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-9c760c90eeacc2181b26bac35bc65329e2f7f591a878a66bb03b740c98bf45e1R9-R27),[[2]](https://github.com/issackjohn/Speedometer/pull/24/files#diff-9c760c90eeacc2181b26bac35bc65329e2f7f591a878a66bb03b740c98bf45e1L52-R63))