Fixes issue with asset deinitialization due to torch > 2.1 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a repro for Isaac Sim team in the MR. ./isaaclab.sh -p source/extensions/omni.isaac.lab/test/dep/isaacsim/check_ref_count.py |
Dhoeller19
approved these changes
Jul 4, 2024
mohanksriram
pushed a commit
to mohanksriram/IsaacLab
that referenced
this pull request
Jul 12, 2024
…#640) # Description Ever since we upgraded the torch version from 2.0.1 (in Isaac Sim 2023.1.1) to 2.2 (in Isaac Sim 4.0), we have seen some of the tests (such as `test_articulation.py`) fail due to improper deinitialization of the created class. This MR fixes this issue by creating a dummy tensor inside the `SimulationContext` in Isaac Lab. While this is a hack, it is effective and helps alleviate the problem. It is hard to figure out the root cause without really understanding what changed on the torch side. Fixes isaac-sim#639 ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
…#640) # Description Ever since we upgraded the torch version from 2.0.1 (in Isaac Sim 2023.1.1) to 2.2 (in Isaac Sim 4.0), we have seen some of the tests (such as `test_articulation.py`) fail due to improper deinitialization of the created class. This MR fixes this issue by creating a dummy tensor inside the `SimulationContext` in Isaac Lab. While this is a hack, it is effective and helps alleviate the problem. It is hard to figure out the root cause without really understanding what changed on the torch side. Fixes isaac-sim#639 ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…#640) # Description Ever since we upgraded the torch version from 2.0.1 (in Isaac Sim 2023.1.1) to 2.2 (in Isaac Sim 4.0), we have seen some of the tests (such as `test_articulation.py`) fail due to improper deinitialization of the created class. This MR fixes this issue by creating a dummy tensor inside the `SimulationContext` in Isaac Lab. While this is a hack, it is effective and helps alleviate the problem. It is hard to figure out the root cause without really understanding what changed on the torch side. Fixes isaac-sim#639 ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ever since we upgraded the torch version from 2.0.1 (in Isaac Sim 2023.1.1) to 2.2 (in Isaac Sim 4.0), we have seen some of the tests (such as
test_articulation.py) fail due to improper deinitialization of the created class.This MR fixes this issue by creating a dummy tensor inside the
SimulationContextin Isaac Lab. While this is a hack, it is effective and helps alleviate the problem. It is hard to figure out the root cause without really understanding what changed on the torch side.Fixes #639
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there