-
Notifications
You must be signed in to change notification settings - Fork 3k
Adds develop branch to CI jobs #4438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile SummaryThis PR renames the branch from Critical Issue Found:
Other Changes:
Confidence Score: 1/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as Pull Request
participant Build as Build Workflow
participant CheckLinks as Check Links
participant Docs as Docs Workflow
participant PostMerge as Post-Merge CI
Dev->>PR: Create PR to develop
PR->>Build: Trigger on PR to develop/main/release
Build->>Build: Run tests
Build->>Build: Combine results
Build->>PR: Post test results
Dev->>PR: Modify documentation
PR->>CheckLinks: Trigger on docs changes
CheckLinks->>CheckLinks: Check for broken links
CheckLinks->>PR: Report link status
PR->>Docs: Trigger on PR
Docs->>Docs: Build documentation
Docs->>Docs: Check if deploy needed
Dev->>PR: Merge to develop
PR->>PostMerge: Push to develop branch
PostMerge->>PostMerge: Build Docker images
PostMerge->>PostMerge: Push images to registry
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
.github/workflows/docs.yaml, line 31 (link)logic: Inconsistency:
develshould bedevelopto match the updated branch trigger on line 12.
4 files reviewed, 1 comment
Description
Enables CI jobs for develop branch.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there