Skip to content

Conversation

@kellyguo11
Copy link
Contributor

Description

Enables CI jobs for develop branch.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 23, 2026

Greptile Summary

This PR renames the branch from devel to develop across four CI workflow files to standardize branch naming.

Critical Issue Found:

  • .github/workflows/docs.yaml has an inconsistency where the workflow trigger was updated to develop but the secret check condition at line 31 still references devel, which will prevent documentation deployment for the develop branch

Other Changes:

  • .github/workflows/build.yml - correctly updated PR trigger
  • .github/workflows/check-links.yml - correctly updated push trigger
  • .github/workflows/postmerge-ci.yml - correctly updated push trigger

Confidence Score: 1/5

  • This PR has a critical logic error that will break documentation deployment for the develop branch
  • Score of 1 reflects a critical inconsistency in docs.yaml where the branch trigger was updated but the deployment condition was not, causing the workflow to trigger but never deploy documentation for the develop branch. The other three files are correctly updated.
  • .github/workflows/docs.yaml requires immediate attention to fix the hardcoded devel reference at line 31

Important Files Changed

Filename Overview
.github/workflows/build.yml Updated branch name from devel to develop in PR trigger configuration
.github/workflows/check-links.yml Updated branch name from devel to develop in push trigger configuration
.github/workflows/docs.yaml Updated branch name in push trigger, but missed update in secret check condition at line 31 causing workflow logic error
.github/workflows/postmerge-ci.yml Updated branch name from devel to develop in push trigger configuration

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PR as Pull Request
    participant Build as Build Workflow
    participant CheckLinks as Check Links
    participant Docs as Docs Workflow
    participant PostMerge as Post-Merge CI

    Dev->>PR: Create PR to develop
    PR->>Build: Trigger on PR to develop/main/release
    Build->>Build: Run tests
    Build->>Build: Combine results
    Build->>PR: Post test results

    Dev->>PR: Modify documentation
    PR->>CheckLinks: Trigger on docs changes
    CheckLinks->>CheckLinks: Check for broken links
    CheckLinks->>PR: Report link status

    PR->>Docs: Trigger on PR
    Docs->>Docs: Build documentation
    Docs->>Docs: Check if deploy needed
    
    Dev->>PR: Merge to develop
    PR->>PostMerge: Push to develop branch
    PostMerge->>PostMerge: Build Docker images
    PostMerge->>PostMerge: Push images to registry
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. .github/workflows/docs.yaml, line 31 (link)

    logic: Inconsistency: devel should be develop to match the updated branch trigger on line 12.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@kellyguo11 kellyguo11 merged commit 7fa140f into isaac-sim:develop Jan 23, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant