Skip to content

Conversation

@hougantc-nvda
Copy link
Contributor

Description

Remove explicit extension for urdf asset importer version no longer necessary.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added isaac-sim Related to Isaac Sim team isaac-lab Related to Isaac Lab team labels Jan 16, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

This PR removes explicit version constraints for the URDF importer extension to support Isaac Sim 6.0. The changes enable dynamic version resolution by replacing isaacsim.asset.importer.urdf-2.4.36 with isaacsim.asset.importer.urdf across configuration files, source code, and tests.

Key Changes:

  • Removed {version = "2.4.36", exact = true} constraint from apps/isaaclab.python.kit and apps/isaacsim_5/isaaclab.python.kit
  • Updated urdf_converter.py:50-51 to use version-agnostic extension name for enabling and checking extension status
  • Updated test files to use the new extension naming convention
  • Switched XR extension from omni.kit.xr.profile.ar to omni.kit.xr.bundle.generic for Isaac Sim 6.0 Teleop compatibility
  • Added CHANGELOG entry documenting this fix in version 0.50.6

The changes are consistent and complete across all affected files. All references to the versioned extension name have been properly updated.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward version constraint removals that enable Isaac Sim 6.0 compatibility. All references to the versioned extension name have been consistently updated across configuration files, source code, and tests. The modifications follow a clear pattern: removing explicit version constraints to allow dynamic resolution of the URDF importer extension bundled with Isaac Sim 6.0. No logic changes or new functionality was introduced.
  • No files require special attention

Important Files Changed

Filename Overview
apps/isaaclab.python.kit Removed explicit version constraint {version = "2.4.36", exact = true} from URDF importer extension, allowing Isaac Sim 6.0 to use the bundled version
apps/isaaclab.python.xr.openxr.kit Switched from omni.kit.xr.profile.ar to omni.kit.xr.bundle.generic for Isaac Sim 6.0 Teleop compatibility
source/isaaclab/isaaclab/sim/converters/urdf_converter.py Updated extension name from isaacsim.asset.importer.urdf-2.4.36 to isaacsim.asset.importer.urdf for dynamic version resolution
source/isaaclab/test/sim/test_spawn_from_files.py Updated test to use version-agnostic URDF extension name for Isaac Sim 6.0 compatibility
source/isaaclab/test/sim/test_urdf_converter.py Updated test to use version-agnostic URDF extension name for Isaac Sim 6.0 compatibility

Sequence Diagram

sequenceDiagram
    participant User
    participant UrdfConverter
    participant ExtensionManager
    participant UrdfInterface
    participant IsaacSim6

    User->>UrdfConverter: Initialize with UrdfConverterCfg
    UrdfConverter->>ExtensionManager: Check if "isaacsim.asset.importer.urdf" enabled
    Note over ExtensionManager,IsaacSim6: Version-agnostic extension name<br/>allows Isaac Sim 6.0 to resolve<br/>to bundled version
    ExtensionManager-->>UrdfConverter: Extension not enabled
    UrdfConverter->>ExtensionManager: enable_extension("isaacsim.asset.importer.urdf")
    ExtensionManager->>IsaacSim6: Load bundled URDF importer
    IsaacSim6-->>ExtensionManager: Extension loaded
    ExtensionManager-->>UrdfConverter: Extension enabled
    UrdfConverter->>UrdfInterface: acquire_urdf_interface()
    UrdfInterface-->>UrdfConverter: URDF interface instance
    UrdfConverter-->>User: Converter ready
Loading

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

# Isaac Sim Extra
"isaacsim.asset.importer.mjcf" = {}
"isaacsim.asset.importer.urdf" = {version = "2.4.36", exact = true}
"isaacsim.asset.importer.urdf" = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this for the 5.X app files since we want to use this exact version for 5.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This app doesn't work for 5.0: #4384

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do version specific app files (for 5.0) as well?

@hougantc-nvda hougantc-nvda reopened this Jan 22, 2026
@kellyguo11 kellyguo11 changed the title For IsaacSim 6.0, remove explicit urdf asset importer extension version Remove explicit urdf asset importer extension version for Isaac Sim 6 Jan 22, 2026
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
@kellyguo11 kellyguo11 changed the title Remove explicit urdf asset importer extension version for Isaac Sim 6 Removes explicit urdf asset importer extension version for Isaac Sim 6 Jan 22, 2026
@kellyguo11 kellyguo11 merged commit 68a955d into isaac-sim:feature/isaacsim-6-0 Jan 22, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants