-
Notifications
You must be signed in to change notification settings - Fork 3k
Removes explicit urdf asset importer extension version for Isaac Sim 6 #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes explicit urdf asset importer extension version for Isaac Sim 6 #4408
Conversation
Greptile SummaryThis PR removes explicit version constraints for the URDF importer extension to support Isaac Sim 6.0. The changes enable dynamic version resolution by replacing Key Changes:
The changes are consistent and complete across all affected files. All references to the versioned extension name have been properly updated. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UrdfConverter
participant ExtensionManager
participant UrdfInterface
participant IsaacSim6
User->>UrdfConverter: Initialize with UrdfConverterCfg
UrdfConverter->>ExtensionManager: Check if "isaacsim.asset.importer.urdf" enabled
Note over ExtensionManager,IsaacSim6: Version-agnostic extension name<br/>allows Isaac Sim 6.0 to resolve<br/>to bundled version
ExtensionManager-->>UrdfConverter: Extension not enabled
UrdfConverter->>ExtensionManager: enable_extension("isaacsim.asset.importer.urdf")
ExtensionManager->>IsaacSim6: Load bundled URDF importer
IsaacSim6-->>ExtensionManager: Extension loaded
ExtensionManager-->>UrdfConverter: Extension enabled
UrdfConverter->>UrdfInterface: acquire_urdf_interface()
UrdfInterface-->>UrdfConverter: URDF interface instance
UrdfConverter-->>User: Converter ready
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
apps/isaacsim_5/isaaclab.python.kit
Outdated
| # Isaac Sim Extra | ||
| "isaacsim.asset.importer.mjcf" = {} | ||
| "isaacsim.asset.importer.urdf" = {version = "2.4.36", exact = true} | ||
| "isaacsim.asset.importer.urdf" = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this for the 5.X app files since we want to use this exact version for 5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This app doesn't work for 5.0: #4384
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably do version specific app files (for 5.0) as well?
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
68a955d
into
isaac-sim:feature/isaacsim-6-0
Description
Remove explicit extension for urdf asset importer version no longer necessary.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there