Skip to content

Updates starlette to 0.49.1 due to security vulnerability#4133

Merged
kellyguo11 merged 1 commit into
isaac-sim:mainfrom
kellyguo11:update-starlette
Dec 3, 2025
Merged

Updates starlette to 0.49.1 due to security vulnerability#4133
kellyguo11 merged 1 commit into
isaac-sim:mainfrom
kellyguo11:update-starlette

Conversation

@kellyguo11

Copy link
Copy Markdown
Contributor

Description

Updates starlette to 0.49.1 due to security vulnerability in the previously used 0.45.3.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Dec 3, 2025
@greptile-apps

greptile-apps Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Greptile Overview

Greptile Summary

Updated starlette dependency from version 0.45.3 to 0.49.1 to address a security vulnerability. This change affects the livestream functionality used for WebRTC streaming in Isaac Lab.

  • Single line change updating the pinned version in setup.py
  • starlette is used for livestream/WebRTC functionality based on codebase context
  • Version jump from 0.45.3 to 0.49.1 includes multiple minor versions (0.46.x, 0.47.x, 0.48.x, 0.49.x)

Confidence Score: 4/5

  • This PR is safe to merge with low risk, though testing livestream functionality is recommended
  • Score reflects a straightforward security patch with minimal code change. Single dependency version update addressing a known vulnerability. However, the version jump spans multiple minor releases (0.45→0.49), which could introduce API changes. The codebase doesn't directly import starlette in Python code (only used as dependency), reducing risk of breaking changes. Recommend testing livestream/WebRTC functionality before merging.
  • No files require special attention - single dependency version update

Important Files Changed

File Analysis

Filename Score Overview
source/isaaclab/setup.py 5/5 Updated starlette from 0.45.3 to 0.49.1 to address security vulnerability

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Setup as setup.py
    participant Pip as Package Manager
    participant Starlette as Starlette Library
    participant App as Isaac Lab App
    
    Dev->>Setup: Update starlette version
    Note over Setup: starlette==0.45.3 → 0.49.1
    Dev->>Pip: Install dependencies
    Pip->>Starlette: Install starlette 0.49.1
    Starlette-->>Pip: Security patches included
    Pip-->>Dev: Installation complete
    Dev->>App: Launch with livestream enabled
    App->>Starlette: Use for WebRTC streaming
    Note over Starlette: Secure version used
    Starlette-->>App: Livestream functionality
Loading

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@kellyguo11 kellyguo11 merged commit 64ecea2 into isaac-sim:main Dec 3, 2025
10 of 12 checks passed
kellyguo11 added a commit that referenced this pull request Dec 3, 2025
# Description

Updates starlette to 0.49.1 due to security vulnerability in the
previously used 0.45.3.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
Edify0991 pushed a commit to Edify0991/IsaacLab that referenced this pull request Jan 14, 2026
…4133)

# Description

Updates starlette to 0.49.1 due to security vulnerability in the
previously used 0.45.3.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
nitesh-subedi pushed a commit to nitesh-subedi/IsaacLab that referenced this pull request Feb 5, 2026
…4133)

# Description

Updates starlette to 0.49.1 due to security vulnerability in the
previously used 0.45.3.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant