Skip to content

Conversation

@kellyguo11
Copy link
Contributor

@kellyguo11 kellyguo11 commented Nov 19, 2025

Description

Frees up more space at the start of the licence checker job so that we have enough disk space to install all the dependencies needed to avoid the out of space errors.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 marked this pull request as draft November 19, 2025 19:23
@github-actions github-actions bot added bug Something isn't working infrastructure labels Nov 19, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Added disk space cleanup commands (rm -rf /usr/share/dotnet, /opt/ghc) and Docker resource pruning to prevent out-of-space errors during dependency installation
  • Ensures sufficient disk space is available before installing IsaacSim and IsaacLab dependencies in the license check workflow

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it addresses a known disk space issue with standard cleanup commands
  • The changes add well-established disk space cleanup operations commonly used in GitHub Actions workflows. The commands are low-risk (rm -rf on standard paths and Docker pruning), and directly address the stated problem of out-of-space errors during dependency installation. Minor consideration: docker volume prune could benefit from error handling.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/license-check.yaml Added cleanup commands to remove dotnet, GHC, and Docker resources to free up disk space before dependency installation

Sequence Diagram

sequenceDiagram
    participant PR as "Pull Request"
    participant GHA as "GitHub Actions"
    participant Runner as "Ubuntu Runner"
    participant Python as "Python Setup"
    participant Isaac as "IsaacLab"
    
    PR->>GHA: "Trigger workflow (opened/synchronize/reopened)"
    GHA->>Runner: "Checkout code"
    Runner->>Runner: "Clean up disk space (rm -rf dotnet, ghc, hostedtoolcache)"
    Runner->>Runner: "Docker cleanup (prune containers, images, volumes)"
    GHA->>Python: "Set up Python 3.11"
    Python->>Isaac: "Install isaacsim from pypi.nvidia.com"
    Isaac->>Isaac: "Run ./isaaclab.sh -i"
    Isaac->>Isaac: "Install pip-licenses and dependencies"
    Isaac->>Isaac: "Generate license report"
    Isaac->>Isaac: "Check licenses against whitelist"
    Isaac-->>GHA: "Return license check result"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@kellyguo11 kellyguo11 marked this pull request as ready for review November 19, 2025 19:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: ooctipus <zhengyuz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants