Fixes keyboard unsubscribe carb call #3662
Open
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
rwiltz
requested review from
Mayankm96,
kellyguo11,
pascal-roth and
peterd-NV
…_to_keyboard_events
rwiltz
force-pushed
the
rwiltz/fix_keyboard_unsubscribe
branch
from
3695a94 to
994761e
Compare
|
Please ensure that you tick the checklist correctly and based on the changes being made. I don't see any tests or doc fixes coming with this update, yet they have been marked. I am unmarking this for now for you but please be careful. |
Mayankm96
reviewed
Oct 10, 2025
| def __del__(self): | ||
| """Release the keyboard interface.""" | ||
| self._input.unsubscribe_from_keyboard_events(self._keyboard, self._keyboard_sub) | ||
| self._input.unsubscribe_to_keyboard_events(self._keyboard, self._keyboard_sub) |
There was a problem hiding this comment.
Is this Isaac SIm 5.1 specific or also holds for prior version of Isaac Sim 4.5?
There was a problem hiding this comment.
Is this Isaac SIm 5.1 specific or also holds for prior version of Isaac Sim 4.5?
I tested on 5.1 and 5.0. Do we need to support 4.5 as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SE3 and SE2 keyboard devices would attempt to unsubscribe from carb keyboard events using the misspelled "unsubscribe_from_keyboard_events" call. The correct function is "unsubscribe_to_keyboard_events".
Fixes # (issue)
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there