Skip to content

Conversation

yijieg
Copy link
Collaborator

@yijieg yijieg commented Oct 9, 2025

Description

  • Fixes the warning messages reported in the QA testing
  • Remove redundant config argument 'sample_from'
  • Change the default value of config argument 'num_log_traj'

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@yijieg yijieg requested a review from kellyguo11 as a code owner October 9, 2025 21:58
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Oct 9, 2025
Copy link

Test Results Summary

2 547 tests   2 085 ✅  2h 27m 12s ⏱️
   96 suites    460 💤
    1 files        1 ❌  1 🔥

For more details on these failures and errors, see this check.

Results for commit 5d1ee06.

Comment on lines +126 to +127
gamma = torch.tensor([gamma], dtype=torch.float, device="cuda")
bandwidth = torch.tensor([bandwidth], dtype=torch.float, device="cuda")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this using "cuda" and not the dev itself? Not sure if this will work nicely on multi-gpu setup?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not run AutoMate env with multi-gpu setting. Could you please suggest how to change device='cuda' for multi-gpu setting? Any example of this?

Comment on lines +64 to +66
bash_command = "NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS=0 isaaclab.bat -p"
elif sys.platform.startswith("linux"):
bash_command = "./isaaclab.sh -p"
bash_command = "NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS=0 ./isaaclab.sh -p"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS do here specifically? Could you add a comment in the code if it needed for something specific?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a easy fix for the reported warning "/colossus/isaaclab/venv_sim_pip_lab_src/lib/python3.11/site-packages/numba/cuda/dispatcher.py:536: NumbaPerformanceWarning: Grid size 1 will likely result in GPU under-utilization due to low occupancy.
warn(NumbaPerformanceWarning(msg))
[2025-07-23 22:33:10,045][numba.cuda.cudadrv.driver][INFO] - init
/colossus/isaaclab/venv_sim_pip_lab_src/lib/python3.11/site-packages/numba/cuda/dispatcher.py:536: NumbaPerformanceWarning: Grid size 1 will likely result in GPU under-utilization due to low occupancy.
warn(NumbaPerformanceWarning(msg))".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants