Fixes CI to fail the job for a fork PRs when general tests fail #3412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add step to check test results for PRs from forks - Parse XML test report to detect failures/errors - Fail job immediately if tests don't pass for fork PRs - Maintain existing behavior for same-repo PRs
nv-apoddubny
requested review from
hhansen-bdai and
kellyguo11
as code owners
kellyguo11
changed the title
kellyguo11
pushed a commit
that referenced
this pull request
Sep 10, 2025
# Description Fail the pre-merge CI job for a fork PRs when general tests fail - Add step to check test results for PRs from forks - Parse XML test report to detect failures/errors - Fail job immediately if tests don't pass for fork PRs - Maintain existing behavior for same-repo PRs ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
ooctipus
pushed a commit
to ooctipus/IsaacLab
that referenced
this pull request
Sep 20, 2025
…c-sim#3412) # Description Fail the pre-merge CI job for a fork PRs when general tests fail - Add step to check test results for PRs from forks - Parse XML test report to detect failures/errors - Fail job immediately if tests don't pass for fork PRs - Maintain existing behavior for same-repo PRs ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fail the pre-merge CI job for a fork PRs when general tests fail
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there