Disables generate internal template when detecting isaaclab install via pip #3225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooctipus
requested review from
Mayankm96,
hhansen-bdai,
jtigue-bdai and
kellyguo11
as code owners
Test Results Summary1 702 tests 1 700 ✅ 52m 53s ⏱️ Results for commit e7d1666. ♻️ This comment has been updated with latest results. |
ooctipus
force-pushed
the
fix/disable_internal_template_pip
branch
2 times, most recently
from
717c567 to
e7d1666
Compare
ooctipus
force-pushed
the
fix/disable_internal_template_pip
branch
from
e7d1666 to
b11fbba
Compare
kellyguo11
approved these changes
Aug 27, 2025
george-nehma
pushed a commit
to george-nehma/DreamLander-IsaacLab
that referenced
this pull request
Oct 24, 2025
…ia pip (isaac-sim#3225) # Description If Isaac Lab is installed through pip, tasks generated with the Internal template cannot be placed inside the site-packages directory of that installation. Since this setup would never work correctly, it makes no sense to offer the Internal template as an option. This PR therefore disables that option entirely whenever Isaac Lab is detected as running from a pip-installed path. Fixes # (issue) ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If Isaac Lab is installed through pip, tasks generated with the Internal template cannot be placed inside the site-packages directory of that installation. Since this setup would never work correctly, it makes no sense to offer the Internal template as an option. This PR therefore disables that option entirely whenever Isaac Lab is detected as running from a pip-installed path.
Fixes # (issue)
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there