Skip to content

Conversation

@KyleM73
Copy link
Contributor

@KyleM73 KyleM73 commented Aug 19, 2025

Description

The terrain_out_of_bounds termination condition creates an error with single environments when called on an infinite plane because it returns the boolean False. This PR replaces the return in this case with a boolean tensor of size (num_envs,).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@KyleM73 KyleM73 requested a review from Mayankm96 as a code owner August 19, 2025 17:04
@ooctipus ooctipus changed the title [Bug Fix] Fixes single-env handling of terrain out of bounds termination Fixes single-env handling of terrain out of bounds termination Aug 21, 2025
@Mayankm96
Copy link
Contributor

Thanks for the MR! Closing since it is duplicate of: #3180

@Mayankm96 Mayankm96 closed this Aug 28, 2025
@Mayankm96 Mayankm96 added the duplicate This issue or pull request already exists label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants