Adds hf-xet license #3116
Merged
Adds hf-xet license #3116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhansen-bdai
requested review from
Mayankm96,
jtigue-bdai and
kellyguo11
as code owners
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
# Description It appears that `isaaclab` transitively depends on `hf-xet`, (a `huggingface`-developed data storage paradigm) via the following dependency chain: ``` Collecting hf-xet<2.0.0,>=1.1.3 (from huggingface-hub<1.0,>=0.34.0->transformers->isaaclab==0.41.5) ``` This results in a failing license check. This PR adds the relevant license from this [repo](https://github.com/huggingface/xet-core) **UPDATE:** I have also added the initialization of `FAILED_PACKAGES=0` in `license-check.yaml` in order to avoid the error I was encountering when no packages were failing: <img width="1461" height="210" alt="image" src="https://github.com/user-attachments/assets/5845626e-2e5c-493f-8356-ae00667ab9ea" /> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
george-nehma
pushed a commit
to george-nehma/DreamLander-IsaacLab
that referenced
this pull request
Oct 24, 2025
# Description It appears that `isaaclab` transitively depends on `hf-xet`, (a `huggingface`-developed data storage paradigm) via the following dependency chain: ``` Collecting hf-xet<2.0.0,>=1.1.3 (from huggingface-hub<1.0,>=0.34.0->transformers->isaaclab==0.41.5) ``` This results in a failing license check. This PR adds the relevant license from this [repo](https://github.com/huggingface/xet-core) **UPDATE:** I have also added the initialization of `FAILED_PACKAGES=0` in `license-check.yaml` in order to avoid the error I was encountering when no packages were failing: <img width="1461" height="210" alt="image" src="https://github.com/user-attachments/assets/5845626e-2e5c-493f-8356-ae00667ab9ea" /> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that
isaaclabtransitively depends onhf-xet, (ahuggingface-developed data storage paradigm) via the following dependency chain:This results in a failing license check. This PR adds the relevant license from this repo
UPDATE: I have also added the initialization of
FAILED_PACKAGES=0inlicense-check.yamlin order to avoid the error I was encountering when no packages were failing:Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there