Extends ContactSensorData by force_matrix_w_history attribute
#2916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikcrum
requested review from
Mayankm96,
jsmith-bdai,
jtigue-bdai and
kellyguo11
as code owners
bikcrum
force-pushed
the
lukasfro/feature/force_matrix_w_history_update
branch
from
3b52d23 to
f9c06b3
Compare
kellyguo11
changed the title
ContactSensorData by force_matrix_w_history attributeContactSensorData by force_matrix_w_history attribute
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Contributor
|
@bikcrum Thank you so much for getting this merged! Frankly, I completely forgot that I opened this PR. I appreciate the attribution of the original authorship 🙂 |
6 tasks
harry-wf-cheung
pushed a commit
to harry-wf-cheung/IsaacLab-Harry
that referenced
this pull request
Jul 30, 2025
…aac-sim#2916) # Description This is a follow-up to isaac-sim#1746 by @lukasfro — thanks for the great work there! I’ve been using this feature and found it really helpful. Since the only remaining request was to resolve merge conflicts and the PR has been quiet for a bit, I went ahead and rebased it on the latest `main` to help move things forward. I branched directly off @lukasfro’s [original branch](https://github.com/lukasfro/IsaacLab/tree/feature/force_matrix_w_history) to preserve their authorship, and only applied the changes needed to resolve the conflicts. Of course, if @lukasfro prefers to continue the original PR, I’m more than happy to close this. Just hoping to be helpful and support getting this great addition merged. All credit for the original work goes to @lukasfro. Fixes isaac-sim#1720 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: lukasfro <lukas.froehlich@swiss-mile.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
kellyguo11
added a commit
that referenced
this pull request
Aug 7, 2025
) This is a follow-up to #1746 by @lukasfro — thanks for the great work there! I’ve been using this feature and found it really helpful. Since the only remaining request was to resolve merge conflicts and the PR has been quiet for a bit, I went ahead and rebased it on the latest `main` to help move things forward. I branched directly off @lukasfro’s [original branch](https://github.com/lukasfro/IsaacLab/tree/feature/force_matrix_w_history) to preserve their authorship, and only applied the changes needed to resolve the conflicts. Of course, if @lukasfro prefers to continue the original PR, I’m more than happy to close this. Just hoping to be helpful and support getting this great addition merged. All credit for the original work goes to @lukasfro. Fixes #1720 - New feature (non-breaking change which adds functionality) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: lukasfro <lukas.froehlich@swiss-mile.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
…aac-sim#2916) # Description This is a follow-up to isaac-sim#1746 by @lukasfro — thanks for the great work there! I’ve been using this feature and found it really helpful. Since the only remaining request was to resolve merge conflicts and the PR has been quiet for a bit, I went ahead and rebased it on the latest `main` to help move things forward. I branched directly off @lukasfro’s [original branch](https://github.com/lukasfro/IsaacLab/tree/feature/force_matrix_w_history) to preserve their authorship, and only applied the changes needed to resolve the conflicts. Of course, if @lukasfro prefers to continue the original PR, I’m more than happy to close this. Just hoping to be helpful and support getting this great addition merged. All credit for the original work goes to @lukasfro. Fixes isaac-sim#1720 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: lukasfro <lukas.froehlich@swiss-mile.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
…aac-sim#2916) This is a follow-up to isaac-sim#1746 by @lukasfro — thanks for the great work there! I’ve been using this feature and found it really helpful. Since the only remaining request was to resolve merge conflicts and the PR has been quiet for a bit, I went ahead and rebased it on the latest `main` to help move things forward. I branched directly off @lukasfro’s [original branch](https://github.com/lukasfro/IsaacLab/tree/feature/force_matrix_w_history) to preserve their authorship, and only applied the changes needed to resolve the conflicts. Of course, if @lukasfro prefers to continue the original PR, I’m more than happy to close this. Just hoping to be helpful and support getting this great addition merged. All credit for the original work goes to @lukasfro. Fixes isaac-sim#1720 - New feature (non-breaking change which adds functionality) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: lukasfro <lukas.froehlich@swiss-mile.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
george-nehma
pushed a commit
to george-nehma/DreamLander-IsaacLab
that referenced
this pull request
Oct 24, 2025
…aac-sim#2916) This is a follow-up to isaac-sim#1746 by @lukasfro — thanks for the great work there! I’ve been using this feature and found it really helpful. Since the only remaining request was to resolve merge conflicts and the PR has been quiet for a bit, I went ahead and rebased it on the latest `main` to help move things forward. I branched directly off @lukasfro’s [original branch](https://github.com/lukasfro/IsaacLab/tree/feature/force_matrix_w_history) to preserve their authorship, and only applied the changes needed to resolve the conflicts. Of course, if @lukasfro prefers to continue the original PR, I’m more than happy to close this. Just hoping to be helpful and support getting this great addition merged. All credit for the original work goes to @lukasfro. Fixes isaac-sim#1720 - New feature (non-breaking change which adds functionality) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: lukasfro <lukas.froehlich@swiss-mile.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #1746 by @lukasfro — thanks for the great work there!
I’ve been using this feature and found it really helpful. Since the only remaining request was to resolve merge conflicts and the PR has been quiet for a bit, I went ahead and rebased it on the latest
mainto help move things forward.I branched directly off @lukasfro’s original branch to preserve their authorship, and only applied the changes needed to resolve the conflicts.
Of course, if @lukasfro prefers to continue the original PR, I’m more than happy to close this. Just hoping to be helpful and support getting this great addition merged.
All credit for the original work goes to @lukasfro.
Fixes #1720
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there