Managed environments actions / observations descriptions #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineRichard
force-pushed
the
antoiner/managed_environments_IO_descriptions
branch
from
d07d009 to
0cbff3d
Compare
AntoineRichard
force-pushed
the
antoiner/managed_environments_IO_descriptions
branch
from
278696c to
60d9480
Compare
AntoineRichard
force-pushed
the
antoiner/managed_environments_IO_descriptions
branch
from
7e3b4c3 to
f859272
Compare
AntoineRichard
requested review from
Mayankm96,
jsmith-bdai and
kellyguo11
as code owners
docs/source/policy_deployment/01_io_descriptors/io_descriptors_101.rst
Outdated
Show resolved
Hide resolved
lgulich
reviewed
Aug 5, 2025
|
|
||
| for group_name in self._group_obs_term_names: | ||
| group_data[group_name] = [] | ||
| # check ig group name is valid |
Contributor
There was a problem hiding this comment.
Suggested change
| # check ig group name is valid | |
| # check if group name is valid |
| They always take the output tensor of the observation term as the first argument, and the descriptor as the second argument. | ||
| In the ``kwargs`` all the inputs of the observation term are provided. In addition to the ``on_inspect`` functions, the decorator | ||
| will also call run some functions in the background to collect the ``name``, the ``description``, and the ``full_path`` of the |
There was a problem hiding this comment.
Suggested change
| will also call run some functions in the background to collect the ``name``, the ``description``, and the ``full_path`` of the | |
| will also run some functions in the background to collect the ``name``, the ``description``, and the ``full_path`` of the |
| self._IO_descriptor.clip = None | ||
| return self._IO_descriptor | ||
| This is it! You should now be able to attach an IO descriptor to your own custom action terms which concludes this tutorial. |
… resolve function to get more data out of the term.
…ess. There are some caveats so we'll need good doc for it
…s. The new decorator can mock its signature, so we don't need that anymore
AntoineRichard
force-pushed
the
antoiner/managed_environments_IO_descriptions
branch
from
da653d5 to
3f6cdee
Compare
Test Results Summary1 690 tests 1 688 ✅ 57m 7s ⏱️ Results for commit 3f6cdee. |
Signed-off-by: ooctipus <zhengyuz@nvidia.com>
george-nehma
pushed a commit
to george-nehma/DreamLander-IsaacLab
that referenced
this pull request
Oct 24, 2025
) # Description Experimental branch to generate observations and actions descriptions from managed environments. ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: ooctipus <zhengyuz@nvidia.com> Co-authored-by: ooctipus <zhengyuz@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Experimental branch to generate observations and actions descriptions from managed environments.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there