Disables extension auto-reload when saving files #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
requested changes
Feb 6, 2025
Contributor
Mayankm96
left a comment
Mayankm96
left a comment
There was a problem hiding this comment.
Is this extension specific or we should disable it completely for all the extensions when launching the simulator from Python?
Contributor
Author
|
I believe it's a setting we have to add for each extension, seems like it's only available through the extension.toml file. |
Mayankm96
approved these changes
Feb 12, 2025
jtigue-bdai
pushed a commit
that referenced
this pull request
Apr 14, 2025
# Description Since extensions are now added to the app files, they get automatically reloaded when changes happen in the extension scripts. This feature is most likely not useful for Isaac Lab development workflows. This change disables the hot reload feature as it causes confusion and unnecessary reloading of the modules. Fixes #1779 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
ToxicNS
pushed a commit
to ToxicNS/IsaacLab
that referenced
this pull request
Apr 24, 2025
# Description Since extensions are now added to the app files, they get automatically reloaded when changes happen in the extension scripts. This feature is most likely not useful for Isaac Lab development workflows. This change disables the hot reload feature as it causes confusion and unnecessary reloading of the modules. Fixes isaac-sim#1779 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
SevenFo
pushed a commit
to SevenFo/IsaacLab
that referenced
this pull request
May 19, 2025
# Description Since extensions are now added to the app files, they get automatically reloaded when changes happen in the extension scripts. This feature is most likely not useful for Isaac Lab development workflows. This change disables the hot reload feature as it causes confusion and unnecessary reloading of the modules. Fixes isaac-sim#1779 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since extensions are now added to the app files, they get automatically reloaded when changes happen in the extension scripts. This feature is most likely not useful for Isaac Lab development workflows. This change disables the hot reload feature as it causes confusion and unnecessary reloading of the modules.
Fixes #1779
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there