Adds interval resampling on event manager's reset call #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
jtigue-bdai
pushed a commit
that referenced
this pull request
Apr 14, 2025
# Description Previously on episodic resets, the "time left" for the interval events were not getting resampled. This means that if the user expects the event to happen in the range 6-8s of an episode, it could be that in a new episode, the push happens at a time outside this range as the time left variable keeps its old value. This MR fixes this issue by resampling the time left inside the manager's reset call. Note: This only matters for the case when "is_global_time" is False (which is the default). The reason is that when there is global time, the events are triggered through simulation time and not episode time. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
SevenFo
pushed a commit
to SevenFo/IsaacLab
that referenced
this pull request
May 19, 2025
# Description Previously on episodic resets, the "time left" for the interval events were not getting resampled. This means that if the user expects the event to happen in the range 6-8s of an episode, it could be that in a new episode, the push happens at a time outside this range as the time left variable keeps its old value. This MR fixes this issue by resampling the time left inside the manager's reset call. Note: This only matters for the case when "is_global_time" is False (which is the default). The reason is that when there is global time, the events are triggered through simulation time and not episode time. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously on episodic resets, the "time left" for the interval events were not getting resampled. This means that if the user expects the event to happen in the range 6-8s of an episode, it could be that in a new episode, the push happens at a time outside this range as the time left variable keeps its old value.
This MR fixes this issue by resampling the time left inside the manager's reset call.
Note: This only matters for the case when "is_global_time" is False (which is the default). The reason is that when there is global time, the events are triggered through simulation time and not episode time.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there