Clarifies Ray Documentation and Fixes Minor Issues #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garylvov
requested review from
Mayankm96,
jsmith-bdai and
kellyguo11
as code owners
… into fix-ray-update
Signed-off-by: garylvov <67614381+garylvov@users.noreply.github.com>
kellyguo11
approved these changes
Jan 25, 2025
kellyguo11
changed the title
jtigue-bdai
pushed a commit
that referenced
this pull request
Apr 14, 2025
# Description This PR cleans up the Ray documentation to be more clear, and fixes some small issues in the code. - Moved local set up to be an easier Docker-based thing - Added Wget to docker container to fix issue where Ray head would fail health check on GKE where the workers wouldn't start - Removed redundant information from Documentation - Added a local quickstart - (investigated whether https mlflow was possible, added flag to jinja env)@kellyguo11 - Added better compatibility with other workflows to address #1703 - Avoided early exit due to buffer overflow to address #1703 (thank you @giulioturrisi for helping find this) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: garylvov <67614381+garylvov@users.noreply.github.com> Co-authored-by: Gary Lvov <glvov@theaiinstitute.com>
SevenFo
pushed a commit
to SevenFo/IsaacLab
that referenced
this pull request
May 19, 2025
# Description This PR cleans up the Ray documentation to be more clear, and fixes some small issues in the code. - Moved local set up to be an easier Docker-based thing - Added Wget to docker container to fix issue where Ray head would fail health check on GKE where the workers wouldn't start - Removed redundant information from Documentation - Added a local quickstart - (investigated whether https mlflow was possible, added flag to jinja env)@kellyguo11 - Added better compatibility with other workflows to address isaac-sim#1703 - Avoided early exit due to buffer overflow to address isaac-sim#1703 (thank you @giulioturrisi for helping find this) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: garylvov <67614381+garylvov@users.noreply.github.com> Co-authored-by: Gary Lvov <glvov@theaiinstitute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the Ray documentation to be more clear, and fixes some small issues in the code.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there