Add configurable object scale for library objects (Rigid Objs) #398
+175
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyao-nv
changed the title
xyao-nv
changed the title
alexmillane
approved these changes
Feb 9, 2026
Comment on lines
91
to
101
| parser.add_argument( | ||
| "--object_scale", | ||
| nargs=3, | ||
| type=float, | ||
| default=None, | ||
| metavar=("X", "Y", "Z"), | ||
| help=( | ||
| "Scale (x, y, z) for the pick-up object(s). Example: --object_scale 1.0 1.0 1.0. If not set, uses the" | ||
| " object's default scale." | ||
| ), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Do we need this as an argument? Seems like something users wont generally use? Do you forsee this being used?
Collaborator
Author
There was a problem hiding this comment.
Yeah I was a bit debating when adding it. I agree the chance of using it thru cli args is low. removed.
xyao-nv
force-pushed
the
xyao/add_obj_scale
branch
from
cbc5eb6 to
587e16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow object scale to be set when instantiating library objects so users can override default scales without changing asset code. Only add it to Rigid Objs.
Detailed description
scale: tuple[float, float, float] | None = NonetoLibraryObject.__init__. If provided, it overrides the class default; otherwise the class scale is used.__init__