Conversation
## Summary Add warnings
## Summary Increase reset openess for the microwave example
alexmillane
left a comment
alexmillane
left a comment
There was a problem hiding this comment.
Looks good!
I have a few minor comments. My only significant request is that we add a test which runs the install script inside a ubuntu22 container and checks that we're left with a valid Arena installation.
Thanks for doing this!
| # Install IsaacLab | ||
| $ISAACLAB_PATH/isaaclab.sh -i $framework_name | ||
| # Install Isaac-GR00T | ||
| ${pip_command} -e "${ISAACLAB_ARENA_PATH}/submodules/Isaac-GR00T" | ||
| # Install IsaacLab Arena | ||
| ${pip_command} -e . |
There was a problem hiding this comment.
This assumes that all dependencies not listed in setup.py are available in the environment this script is being run in, I suppose? Is that correct?
There was a problem hiding this comment.
Edit: I notice you've added some additional dependencies to our setup.py. Nice!
Perhaps with those additions, we have everything we need on some platforms?
I would suggest that we set up a test that runs this script in a ubuntu22 docker, and we're left with a valid Arena installation (i.e. an installation which passes the tests).
There was a problem hiding this comment.
I've tested it on Ubuntu 24, and it works. Do you think it's still necessary to test it in a docker for 22?
|
I just made a clearer PR, which is only for installation outside docker and pycharm debugging. This PR will be closed. #327 |
4 participants
Summary
Add setup for developing without docker
Detailed description