fixes yup currency validation with min #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using our custom 'currency' yup schema with a minimum value we do not catch errors from 'CurrencyUtils.decode'. this results in a non-yup error during validation if the value cannot be decoded. an error other than 'yup.ValidationError' in an RPC endpoint crashes the node. see #3662
updates tests expecting validation error message
danield9tqh
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when using our custom 'currency' yup schema with a minimum value we do not catch errors from 'CurrencyUtils.decode'. this results in a non-yup error during validation if the value cannot be decoded.
an error other than 'yup.ValidationError' in an RPC endpoint crashes the node.
see #3662
Testing Plan
test.diff.txt
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.