fixes yup currency validation with min (#3688)

* fixes yup currency validation with min

when using our custom 'currency' yup schema with a minimum value we do not catch
errors from 'CurrencyUtils.decode'. this results in a non-yup error during
validation if the value cannot be decoded.

an error other than 'yup.ValidationError' in an RPC endpoint crashes the node.

see #3662

* restores unique error message for min

updates tests expecting validation error message

ironfish/src/rpc/routes/wallet/burnAsset.test.ts

@@ -26,7 +26,9 @@ describe('burnAsset', () => {
           fee: '0',
           value: '100',
         }),
-      ).rejects.toThrow('value must be equal to or greater than 1')
+      ).rejects.toThrow(
+        'Request failed (400) validation: value must be equal to or greater than 1',
+      )
     })
   })
 
@@ -39,7 +41,9 @@ describe('burnAsset', () => {
           fee: '1',
           value: '-1',
         }),
-      ).rejects.toThrow('value must be equal to or greater than 1')
+      ).rejects.toThrow(
+        'Request failed (400) validation: value must be equal to or greater than 1',
+      )
     })
   })
 

ironfish/src/rpc/routes/wallet/mintAsset.test.ts

@@ -23,7 +23,9 @@ describe('mint', () => {
           name: 'fake-coin',
           value: '100',
         }),
-      ).rejects.toThrow('value must be equal to or greater than 1')
+      ).rejects.toThrow(
+        'Request failed (400) validation: value must be equal to or greater than 1',
+      )
     })
   })
 
@@ -37,7 +39,9 @@ describe('mint', () => {
           name: 'fake-coin',
           value: '-1',
         }),
-      ).rejects.toThrow('value must be equal to or greater than 1')
+      ).rejects.toThrow(
+        'Request failed (400) validation: value must be equal to or greater than 1',
+      )
     })
   })
 

ironfish/src/utils/yup.test.ts

@@ -35,6 +35,7 @@ describe('YupUtils', () => {
     it('currency', () => {
       expect(YupUtils.currency().isValidSync(CurrencyUtils.encode(6n))).toBe(true)
       expect(YupUtils.currency({ min: 0n }).isValidSync(CurrencyUtils.encode(-1n))).toBe(false)
+      expect(YupUtils.currency({ min: 0n }).isValidSync('0.1')).toBe(false)
       expect(YupUtils.currency().isValidSync('hello world')).toBe(false)
       expect(YupUtils.currency().isValidSync(0.00046)).toBe(false)
     })

ironfish/src/utils/yup.ts

@@ -36,9 +36,16 @@ export class YupUtils {
       const min = options?.min
 
       schema = schema.test(
-        `min`,
+        'min',
         `value must be equal to or greater than ${min.toString()}`,
-        (val) => val == null || CurrencyUtils.decode(val) >= min,
+        (val) => {
+          if (val == null) {
+            return true
+          }
+
+          const [value] = CurrencyUtils.decodeTry(val)
+          return value != null && value >= min
+        },
       )
     }