Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes rescanning wallet to always set account heads #3654

Merged
merged 1 commit into from
Mar 20, 2023

Commits on Mar 15, 2023

  1. fixes rescanning wallet without --reset

    the logic of 'connectBlock' filters any account that does not have its 'head'
    equal to the previous block. this means that if we don't reset account heads
    during rescan nothing will happen.
    
    this is also true of rescanning using the '--from' flag. this flag lets users
    start the rescan at a particular sequence. however, if we don't set account
    heads to that sequence then scanning won't do anything.
    
    - removes the 'reset' option and always resets accounts
    - throws an error if the 'from' sequence is not in the chain or the header at
      that sequence is not on the main chain
    - sets account heads equal to the block header before the from sequence if it is
      not the genesis block
    hughy committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    92db719 View commit details
    Browse the repository at this point in the history