fixes rescanning wallet to always set account heads #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the logic of 'connectBlock' filters any account that does not have its 'head' equal to the previous block. this means that if we don't reset account heads during rescan nothing will happen. this is also true of rescanning using the '--from' flag. this flag lets users start the rescan at a particular sequence. however, if we don't set account heads to that sequence then scanning won't do anything. - removes the 'reset' option and always resets accounts - throws an error if the 'from' sequence is not in the chain or the header at that sequence is not on the main chain - sets account heads equal to the block header before the from sequence if it is not the genesis block
hughy
changed the title
EvanJRichard
approved these changes
Mar 20, 2023
hughy
added a commit
to iron-fish/website
that referenced
this pull request
Mar 21, 2023
following iron-fish/ironfish#3654 'reset' is no longer a request parameter for rescanAccount and all rescans will reset the wallet database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the logic of 'connectBlock' filters any account that does not have its 'head' equal to the previous block. this means that if we don't reset account heads during rescan nothing will happen.
this is also true of rescanning using the '--from' flag. this flag lets users start the rescan at a particular sequence. however, if we don't set account heads to that sequence then scanning won't do anything.
Testing Plan
before:
Finishes scanning almost immediately and then hits an error
after:
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.