Set trait values from static defaults at instance_init#35
Merged
minrk merged 1 commit intoipython:masterfrom Jun 15, 2015
Merged
Set trait values from static defaults at instance_init#35minrk merged 1 commit intoipython:masterfrom
minrk merged 1 commit intoipython:masterfrom
Conversation
Should fix the problem introduced in ipythongh-31 for the widgets. One small behavioural change: traitlets with no default value will raise TraitError when accessed instead of returning Undefined.
Member
|
I checked out Thomas' branch and I can confirm that it fixes the issue. |
Member
Author
|
Thanks. Again, I'd like @minrk to have a quick look before we merge this, but it's a fairly small change. |
Member
|
Well, in any case, there is no risk I merge anything in traitlets :-) |
minrk
added a commit
that referenced
this pull request
Jun 15, 2015
Set trait values from static defaults at instance_init
Member
|
Thanks, guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the problem introduced in gh-31 for the widgets. @SylvainCorlay
One small behavioural change: traitlets with no default value will raise TraitError when accessed instead of returning Undefined.