Merged
Conversation
Member
Author
|
Don't merge this yet, just about to open a conflicting PR |
Closes ipythongh-32 I also removed validate_default_value(), which I just added in PR ipython#31. Its implementation is a single line, so I decided it was clearer to inline it where it's used.
takluyver
force-pushed
the
deprecate-get-default-value
branch
from
0802a2f to
e7c2cff
Compare
Member
Author
|
Rebased now that #35 is merged. @SylvainCorlay , do you want to check that this doesn't break anything with widgets? |
Member
|
👍 will merge after confirmation from @SylvainCorlay |
Member
|
Sorry for the late reply. All the tests run OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-32
I also removed validate_default_value(), which I just added in PR #31. Its implementation is a single line, so I decided it was clearer to inline it where it's used.