Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop_on_error_timeout blocking other messages in queue #539

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Fix stop_on_error_timeout blocking other messages in queue #539

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
012cebb
Use io_loop instead of dispatch queue
glentakahashi Aug 12, 2020
38dda3b
Remove unused
glentakahashi Aug 12, 2020
dbdf864
Bring back log
glentakahashi Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Bring back log
  • Loading branch information
@glentakahashi
glentakahashi authored Aug 18, 2020
commit dbdf8647ab42531d2a6e6186eacfc94c477f555e
1 change: 1 addition & 0 deletions ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@ def _abort_queues(self):
self._aborting = True

def stop_aborting(f):
self.log.info("Finishing abort")
self._aborting = False

self.io_loop.add_future(gen.sleep(self.stop_on_error_timeout), stop_aborting)
Expand Down