Fix stop_on_error_timeout blocking other messages in queue #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation,
stop_on_error_timeout
doesn't work as expected and instead completely blocks the message queue rather than operating as an async callback as intended.Explanation:
stop_on_error_timeout = 0.1
If we send 100 requests at 1 per 0.01 second, and an error occurs after 0.3 seconds (request 30), this is what is expected to happen:
What actually happens:
A more extreme case can be seen if you bump this up to
stop_on_error_timeout = 15
. What happens in this case is:this PR fixes this by moving the "finish abort" callback to the event loop instead of using the existing message queue