Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): remove the need for admin #74

Merged
merged 6 commits into from
Jun 7, 2024
Merged

fix(windows): remove the need for admin #74

merged 6 commits into from
Jun 7, 2024

Commits on Jun 7, 2024

  1. fix(windows): remove the need for admin 

    Seems symllink now triggers admin prompt.
Running NPM with admin is not wise, instead we
fallback to copying when on windows.
    @lidel
    lidel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fa64404 View commit details
    Browse the repository at this point in the history

  2. tets(ci): matrix against mac, windows, and node 

    goal is to catch issues on platforms like windows
    @lidel
    lidel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a3afda7 View commit details
    Browse the repository at this point in the history

  3. fix(windows): remove unix placeholder 

    (cherry picked from commit 9eb4d2a)
    @lidel
    lidel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    dc4603d View commit details
    Browse the repository at this point in the history

  4. test(windows): test presence of .exe

    @lidel
    lidel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    afc3694 View commit details
    Browse the repository at this point in the history

  5. docs(windows): note .exe and symlink workaround

    @lidel
    lidel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    225ffb6 View commit details
    Browse the repository at this point in the history

  6. fix(ci): linux image name

    @lidel
    lidel committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7964ed7 View commit details
    Browse the repository at this point in the history