fix(windows): remove the need for admin #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems symllink now triggers admin prompt. Running NPM with admin is not wise, instead we fallback to copying when on windows.
lidel
force-pushed
the
fix/symlink-error-windows
branch
from
4dcf251
to
f696d7a
Compare
goal is to catch issues on platforms like windows
lidel
force-pushed
the
fix/symlink-error-windows
branch
from
f696d7a
to
a3afda7
Compare
lidel
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Jun 7, 2024
This also tests ipfs/npm-kubo#74 removing the need for hack from #2662
lidel
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Jun 12, 2024
* refactor: macos universal build * refactor: switch to macos-latest (arm) * feat(macos): build universal kubo binary * fix(ci): switch back to lts node This also tests ipfs/npm-kubo#74 removing the need for hack from #2662 * chore: remove coactions/setup-xvfb modern linux image at github includes it out of the box and we use xvfb-maybe internally to use it when appropriate * chore: update .github/CODEOWNERS * chore: kubo v0.29.0 * chore: electron-updater bumping to include: windows fix: https://github.com/electron-userland/electron-builder/releases/tag/electron-updater%406.1.9 macos fix: https://github.com/electron-userland/electron-builder/releases/tag/electron-updater%406.2.1 * chore: ensure release as 0.36.0 Release-As: 0.36.0 Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems symllink now triggers admin prompt.
Running NPM with admin is not wise, instead we fallback to copying when on Windows.
npm i --save kubo@0.29.0-rc2producedEPERMerrornpm i --save ipfs/npm-kubo#pull/74/headinstalled just fine, and without prompting for AdminCloses #68