Pull out relevant tests from interface-ipfs-core

[SgtPooki]

Originally from ipfs/kubo#9125

Not an action item I feel comfortable deciding upon, so I'll leave this for @aschmahmann and @lidel for now.

Kubo RPC Client should have its own tests, stripped out from interface-ipfs-core. And we should only bring over the tests that are applicable for Kubo's supported RPC calls. -- ipfs/kubo#9125 (comment)

• Copy over all tests from interface-ipfs-core (there are a lot) #48
• [ ] Skip (but leave) tests that were being skipped in interface-ipfs-core  #52
• [ ] Fix tests, or skip with brokenDuringKuboRpcClientMigration if significant effort is required #53
• ipfs-http-client migration: Additional tasks #56

[SgtPooki]

@achingbrain @lidel https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/test/interface.spec.js seems to be empty (had it's only line, use strict, removed by ipfs/js-ipfs#3879).

If there are no tests in that package, where should I look for moving old ipfs-http-client tests to this repo?

[BigLep]

@SgtPooki : do you have clarity now on where the relevant tests are?

[SgtPooki]

@BigLep not yet

[achingbrain]

When running tests using ipfs-http-client against go-ipfs the tests are loaded from https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs/test/interface-http-go.js

The complete test suite is imported:

import * as tests from 'interface-ipfs-core'

each member of tests is part of the test suite, you either run all the tests in that suite:

// test ipfs.repo.* commands
tests.repo(commonFactory)

..or you skip some of the tests in the suite because there's been a divergence in the implementations:

// test root commands, e.g. ipfs.add, ipfs.cat, etc
tests.root(commonFactory, {
    skip: [
      {
        name: 'should add with mode as string',
        reason: 'TODO not implemented in go-ipfs yet'
      },
      {
        name: 'should add with mode as number',
        reason: 'TODO not implemented in go-ipfs yet'
      },
      //... etc

Hopefully that helps.

[SgtPooki]

Thanks that helps.