Skip to content

fix: use new glob source API #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix: use new glob source API #1976

merged 2 commits into from
Feb 11, 2022

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Feb 9, 2022 •
edited
Loading

Fixes #1973 and adds unit tests. I also stopped using object.addLink and used the same strategy as in ipfs/ipfs-webui#1890.

@hacdias hacdias requested a review from lidel February 10, 2022 13:09
@hacdias hacdias marked this pull request as ready for review February 10, 2022 13:09
@hacdias
Copy link
Member Author

hacdias commented Feb 10, 2022

@lidel this should fix #1973.

lidel
lidel approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, does the trick on both Windows and macOS 👍

@lidel lidel merged commit 89b0d7f into main Feb 11, 2022
@lidel lidel deleted the fix/1973 branch February 11, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel lidel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OS-native integrations (Windows/macOS) fail with Error: Pattern must be a string

3 participants

@hacdias @lidel