-
Notifications
You must be signed in to change notification settings - Fork 897
Closed
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps uparea/macosMacOSMacOSarea/windowsWindowsWindowsexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulneed/triageNeeds initial labeling and prioritizationNeeds initial labeling and prioritization
Description
Found a bug during manual QA from https://github.com/ipfs/ipfs-desktop/blob/main/DEVELOPER-NOTES.md#manual-testing
This is blocking 0.19 release.
Bug
Build 3bc3a8a fail to import a single file via context menu in Windows' File Explorer with error Error: Pattern must be a string in error.log
Error comes from add-to-ipfs.js (probably similar problem as one fixed in 13de174)
Notes
- fix is most likely fixing type somewhere – needs analysis
- we need unit tests for
add-to-ipfs.js, it breaks too often, every time there are changes in JS API interfaces
Metadata
Metadata
Assignees
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps uparea/macosMacOSMacOSarea/windowsWindowsWindowsexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulneed/triageNeeds initial labeling and prioritizationNeeds initial labeling and prioritization