Skip to content

OS-native integrations (Windows/macOS) fail with Error: Pattern must be a string #1973

@lidel

Description

@lidel

Found a bug during manual QA from https://github.com/ipfs/ipfs-desktop/blob/main/DEVELOPER-NOTES.md#manual-testing
This is blocking 0.19 release.

Bug

Build 3bc3a8a fail to import a single file via context menu in Windows' File Explorer with error Error: Pattern must be a string in error.log

Error comes from add-to-ipfs.js (probably similar problem as one fixed in 13de174)

Notes

  • fix is most likely fixing type somewhere – needs analysis
  • we need unit tests for add-to-ipfs.js, it breaks too often, every time there are changes in JS API interfaces

Metadata

Metadata

Assignees

Labels

P1High: Likely tackled by core team if no one steps uparea/macosMacOSarea/windowsWindowsexp/intermediatePrior experience is likely helpfulneed/triageNeeds initial labeling and prioritization

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions