This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: additional add* validation tests #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
victorb
reviewed
Oct 23, 2018
js/src/files/add.js
Outdated
| }) | ||
| }) | ||
|
|
||
| it('should not be able to add a non-Buffer TypedArray', (done) => { |
There was a problem hiding this comment.
Should this test include more of the different typed arrays?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Typed_arrays#Typed_array_views
There was a problem hiding this comment.
I think that since these all inherit from TypedArray then testing with just one is good enough, the point here is to ensure the API is feeding back with an appropriate message and not passing the input further down the stack where it'll cause an error that doesn't communicate the real problem.
2 tasks
alanshaw
changed the title
alanshaw
changed the title
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
test/add-tests
branch
from
ff17689
to
1ee508f
Compare
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
changed the title
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #292