Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

files.add*Stream coverage is poor #292

Closed
alanshaw opened this issue Jun 6, 2018 · 1 comment
Closed

files.add*Stream coverage is poor #292

alanshaw opened this issue Jun 6, 2018 · 1 comment
Assignees
@alanshaw
Labels
difficulty:moderate enhancement help wanted in progress P1 - High

Comments

@alanshaw
Copy link
Contributor

alanshaw commented Jun 6, 2018

Pulling out tests per command for #290 shows that test coverage for addReadableStream and addPullStream is poor (almost non existent).

Considering files.add is basically most developer's first port of call when starting with IPFS these commands should be rock solid and tested as such.
@alanshaw alanshaw changed the title Files add*Stream coverage is poor files.add*Stream coverage is poor Jun 6, 2018
@alanshaw alanshaw mentioned this issue Oct 23, 2018
Merged
@ghost ghost assigned alanshaw Oct 23, 2018
@ghost ghost added in progress and removed ready labels Oct 23, 2018
@achingbrain
Copy link
Collaborator

This code has mostly been deleted with the async/await refactor, so I don't think there's much to do here now - please open an issue on ipfs/js-ipfs if that's not the case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
difficulty:moderate enhancement help wanted in progress P1 - High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanshaw @achingbrain