Create GUI for configuring deployment#166
Conversation
NadiaHG
left a comment
There was a problem hiding this comment.
The code looks good to me! 👍🏽
I like the idea of the plugin. But It is not working to me when I select a parameter, I think then it should appear a new pop-up windows to set the value but it ends with the following error:
Caused by: java.lang.NullPointerException
at de.fraunhofer.ipa.rossystem.deployment.GenerationHandler.get_component_port_value(GenerationHandler.java:161)
at de.fraunhofer.ipa.rossystem.deployment.GenerationHandler.set_ports_from_parameters(GenerationHandler.java:128)
|
Error only appears if the selected parameter hasn't got a default value. Ideally the plugin will check that, say to the user that the value wasn't set during the design of the system and let him/her to set it "in the loop" for the docker-compose generation. |
1303683 to
e8c5f8d
Compare
I updated. It will tell users: "Null. Didn't find value for this parameter. Please set a value in docker-compose.yml manually." in the pop-up windows. |
|
@ipa-rwu Thanks a lot for the update, now I don't get the error anymore but the text taken from the input is wrong, my generated |
|
@ipa-nhg But probably it is not so clear here. |
e8c5f8d to
f5113ab
Compare
|
In case the user doesn't want to select ports, because is not needed for the target system or because he/she prefers to set the permissions manually and not using parameters values, we have to also be able to generate the deployment artifacts. The current code is giving an error for this use case. @ipa-rwu Please review my suggestion here: ipa-rwu/ros-model#5 |
NadiaHG
left a comment
There was a problem hiding this comment.
Tested with a couple of types of system models and it works as expected! 👍🏽
Thanks a lot!
@ipa-nhg I created Gui for configuring deployment, including: