Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libbpf tools as part of fedora test run #3779

Conversation

davemarchevsky
Copy link
Collaborator

This makes no attempt to CMake-ify libbpf-tools/Makefile, so the build happens as a separate step

There's currently nothing using the generated executables to test, but ostensibly the tests/python/test_tools_smoke.py could be extended to do so. May be worth merging independently as there are lots of outstanding libbpf-tools PRs and quick feedback on whether build succeeds would be useful

Why fedora only? Installing linux-tools-generic package on Ubuntu, which contains bpftool causes problems since Ubuntu's /usr/sbin/bpftool is a script wrapper which tries to ensure that the installed bpftool (located in /usr/lib/linux-tools/...) kernel version matches the running kernel. Normally a useful thing to check. Also bpftools on 18.04 and 20.04 are too old to gen skel. All can be worked around, but needs some thought.

@davemarchevsky
Copy link
Collaborator Author

I expect "Dummy commit" Fedora builds to fail, then builds off a revert commit to succeed

@davemarchevsky davemarchevsky force-pushed the davemarchevsky_build_libbpf_tools branch from bf274d2 to 8c0ee94 Compare January 1, 2022 21:10
@davemarchevsky davemarchevsky merged commit 8cac3fd into iovisor:master Jan 1, 2022
@davemarchevsky davemarchevsky deleted the davemarchevsky_build_libbpf_tools branch January 1, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant