Build libbpf tools as part of fedora test run #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemarchevsky
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
I expect "Dummy commit" Fedora builds to fail, then builds off a revert commit to succeed |
davemarchevsky
force-pushed
the
davemarchevsky_build_libbpf_tools
branch
from
bf274d2 to
8c0ee94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes no attempt to CMake-ify
libbpf-tools/Makefile, so the build happens as a separate stepThere's currently nothing using the generated executables to test, but ostensibly the
tests/python/test_tools_smoke.pycould be extended to do so. May be worth merging independently as there are lots of outstanding libbpf-tools PRs and quick feedback on whether build succeeds would be usefulWhy fedora only? Installing
linux-tools-genericpackage on Ubuntu, which containsbpftoolcauses problems since Ubuntu's/usr/sbin/bpftoolis a script wrapper which tries to ensure that the installed bpftool (located in/usr/lib/linux-tools/...) kernel version matches the running kernel. Normally a useful thing to check. Also bpftools on 18.04 and 20.04 are too old to gen skel. All can be worked around, but needs some thought.