Add libbpf-based tools to container image #3573
Conversation
Signed-off-by: Mauricio Vásquez <mauricio@kinvolk.io>
mauriciovasquezbernal
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
|
||
| RUN cd /root/bcc/src/cc/libbpf/src/ && make | ||
| RUN cd /root/bcc/libbpf-tools/ && \ | ||
| CLANG=clang-10 LLVM_STRIP=llvm-strip-10 make -j $(nproc) DESTDIR=/libbpf-tools/ prefix="" install |
There was a problem hiding this comment.
would it be possible to use a more recent Clang version?
There was a problem hiding this comment.
That's the most recent version shipped with bionic :/. We could use clang-12 if we build the libbpf tools using focal. (I think It'll work just fine to have the build image on focal even if the final container is built with bionic). If you think it's better to use a more recent version I'll switch to that approach.
There was a problem hiding this comment.
Newer Clang has better code generation for BPF, generally. But whether that is important for current versions of libbpf-tools, I don't really know. I was just curious what's the limitations for using newer Clang. I satisfied my curiosity, thanks!
|
Sorry that I didn't review this properly :( . I'm addressing this in a different way in #3779 and future PRs, so we can reach a state where we're building and doing some basic "does this run?" testing of all libbpf-tools. |
This PR extends the dockerfile to also include the tools based on libbpf.