Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split unpublish request into multiple requests #561

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Danielius1922
Copy link
Member

No description provided.

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.


ℹ️ To verify your latest change (bccb03a), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/bugfix/551-unpublish-buffer-too-small branch 6 times, most recently from 1bf2d97 to 86fb6c8 Compare October 28, 2023 17:27
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Oct 28, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/551-unpublish-buffer-too-small branch from 86fb6c8 to 0f8d2ae Compare October 30, 2023 07:10
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Oct 30, 2023
@Danielius1922 Danielius1922 changed the title cloud: use dynamic buffer when generating unpublish resources request Split unpublish request into multiple requests Oct 30, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/551-unpublish-buffer-too-small branch from 0f8d2ae to ba8a070 Compare October 30, 2023 07:19
@Danielius1922 Danielius1922 marked this pull request as ready for review October 30, 2023 07:19
@Danielius1922 Danielius1922 requested a review from jkralik October 30, 2023 07:19
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Oct 30, 2023
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Oct 31, 2023
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Oct 31, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/551-unpublish-buffer-too-small branch from 7e68858 to c3f6a13 Compare October 31, 2023 13:36
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Oct 31, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/551-unpublish-buffer-too-small branch from c3f6a13 to 27f97e9 Compare October 31, 2023 17:18
When attempting to unpublish multiple resource links the query
can exceed the allowed COAP COAP_MAX_HEADER_SIZE limit.
To avoid this issue the query is split between mutliple requests
when necessary.
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/551-unpublish-buffer-too-small branch from 27f97e9 to b4ab698 Compare October 31, 2023 18:07
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

86.8% 86.8% Coverage
0.0% 0.0% Duplication

@Danielius1922 Danielius1922 merged commit 19901c3 into master Oct 31, 2023
120 checks passed
@Danielius1922 Danielius1922 deleted the adam/bugfix/551-unpublish-buffer-too-small branch October 31, 2023 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
@Danielius1922 Danielius1922 linked an issue Oct 31, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too small static buffer used for unpublish device request
2 participants