-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split unpublish request into multiple requests #561
Merged
Danielius1922
merged 1 commit into
master
from
adam/bugfix/551-unpublish-buffer-too-small
Oct 31, 2023
Merged
Split unpublish request into multiple requests #561
Danielius1922
merged 1 commit into
master
from
adam/bugfix/551-unpublish-buffer-too-small
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed. ℹ️ To verify your latest change (bccb03a), label this PR with |
Danielius1922
force-pushed
the
adam/bugfix/551-unpublish-buffer-too-small
branch
6 times, most recently
from
October 28, 2023 17:27
1bf2d97
to
86fb6c8
Compare
Danielius1922
force-pushed
the
adam/bugfix/551-unpublish-buffer-too-small
branch
from
October 30, 2023 07:10
86fb6c8
to
0f8d2ae
Compare
ocf-conformance-test-tool
bot
removed
the
OCF Conformance Testing
OCF Conformance Testing required
label
Oct 30, 2023
Danielius1922
changed the title
cloud: use dynamic buffer when generating unpublish resources request
Split unpublish request into multiple requests
Oct 30, 2023
Danielius1922
force-pushed
the
adam/bugfix/551-unpublish-buffer-too-small
branch
from
October 30, 2023 07:19
0f8d2ae
to
ba8a070
Compare
jkralik
reviewed
Oct 30, 2023
ocf-conformance-test-tool
bot
removed
the
OCF Conformance Testing
OCF Conformance Testing required
label
Oct 31, 2023
jkralik
approved these changes
Oct 31, 2023
Danielius1922
force-pushed
the
adam/bugfix/551-unpublish-buffer-too-small
branch
from
October 31, 2023 13:36
7e68858
to
c3f6a13
Compare
ocf-conformance-test-tool
bot
removed
the
OCF Conformance Testing
OCF Conformance Testing required
label
Oct 31, 2023
Danielius1922
force-pushed
the
adam/bugfix/551-unpublish-buffer-too-small
branch
from
October 31, 2023 17:18
c3f6a13
to
27f97e9
Compare
When attempting to unpublish multiple resource links the query can exceed the allowed COAP COAP_MAX_HEADER_SIZE limit. To avoid this issue the query is split between mutliple requests when necessary.
Danielius1922
force-pushed
the
adam/bugfix/551-unpublish-buffer-too-small
branch
from
October 31, 2023 18:07
27f97e9
to
b4ab698
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.