Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too small static buffer used for unpublish device request #551

Closed
Danielius1922 opened this issue Oct 23, 2023 · 0 comments · Fixed by #561
Closed

Too small static buffer used for unpublish device request #551

Danielius1922 opened this issue Oct 23, 2023 · 0 comments · Fixed by #561
Assignees
@Danielius1922
Labels
2.2.5.10 bug Something isn't working

Comments

@Danielius1922
Copy link
Member

When unpublishing multiple resources from cloud the 256 character static buffer uri_query buffer used by rd_delete_with_device_id can be too small.

Update to use dynamic buffer:

  • calculate the number of resources unpublished (n)
  • calculate the required buffer size to contain ?di=${36 character UUID} + n times "&ins=${64bit integer as string}" + terminator
  • use a buffer of the required size
@Danielius1922 Danielius1922 self-assigned this Oct 23, 2023
@Danielius1922 Danielius1922 added bug Something isn't working 2.2.5.10 labels Oct 23, 2023
@Danielius1922 Danielius1922 linked a pull request Oct 31, 2023 that will close this issue
Split unpublish request into multiple requests #561
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielius1922 Danielius1922

Labels
2.2.5.10 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split unpublish request into multiple requests iotivity/iotivity-lite
1 participant
@Danielius1922