Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install Python 3.10 to fix issues with node-gyp #1613

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Nov 24, 2022

Description of change

This is a workaround for an error while building the Node.js bindings. node-gyp is a primarily Python-based tool to build native modules for Node.js and prebuild is using an old version of it. The root issue is that node-gyp is trying to open a file with the deprecated 'U' mode which was removed in Python 3.11. At this time, only macOS is failing because it's using Python 3.11, but I think it's only a matter of time before the default Python version on Windows and Linux runners are updated (they're currently using 3.8.10).

Links to any relevant issues

N/A

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Building prebuilt binaries succeeds locally using Python 3.10.8

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@rajivshah3 rajivshah3 changed the title fix: Install Python 3.8 to fix issues with node-gyp fix: Install Python 3.10 to fix issues with node-gyp Nov 24, 2022
@rajivshah3 rajivshah3 marked this pull request as ready for review November 24, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants