Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct workflows #1555

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix: correct workflows #1555

merged 1 commit into from
Feb 6, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 6, 2023

Description of change

The prebuild on macOS fail at the moment, because prebuild relies on an outdated node-gyp version that requires python 3.10 to work correctly. The python versions on the CI machine for macOS defaults to 3.11 which causes these issues.

Copy of work done in wallet.rs:
iotaledger/wallet.rs#1613

Links to any relevant issues

closes: #1522

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Tuditi Tuditi added the i-dependencies Infra - Dependencies label Feb 6, 2023
@Tuditi Tuditi self-assigned this Feb 6, 2023
@Thoralf-M Thoralf-M merged commit ca12e5c into develop Feb 6, 2023
@Thoralf-M Thoralf-M deleted the fix/workflow-uses-wrong-python branch February 6, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-dependencies Infra - Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Build Node.js Prebuilds fails
4 participants