-
Notifications
You must be signed in to change notification settings - Fork 58
feat(gRPC): add GetTransactions implementation in gRPC
#9335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bingyanglin
wants to merge
13
commits into
feat/grpc-implementation
Choose a base branch
from
feat/grpc-get-transactions-impl
base: feat/grpc-implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(gRPC): add GetTransactions implementation in gRPC
#9335
bingyanglin
wants to merge
13
commits into
feat/grpc-implementation
from
feat/grpc-get-transactions-impl
+13,392
−1,345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ported field masking mechanism, including - The `field` module - The `iota-proto-build` crate to generate fields, so we can use `FieldMaskUtil::validate` to verify the client-requested field paths. - Change `EventID` to `EventId` to meet `prost`'s naming convention, so the generated Rust code from `protobuf` can be used without additional conversion (like change `ID` to `Id`). Part of #8688 - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes --------- Co-authored-by: muXxer <git@muxxer.de>
# Description of change This PR adds a new transaction filter and a new event filter for gRPC (not used yet by the API). It combines the two existing json-rpc filters into one, but also adds the possibility to filter for transactions that match a certain event filter. Also, the possibility to chain the filters was added (`Any`, `All`, `Or`, `And`) similar to the event filters. ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
# Description of change - Initialize the gRPC proto files, which addressed APIs documented in #8688. - Note that the design of gRPC request/response in is that we focus on returning low-level BCS iota-type data, instead of extracting fields from the iota-type data and put them in response in most cases (to discuss). ## Links to any relevant issues Part of #8688 ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes --------- Co-authored-by: muXxer <git@muxxer.de>
# Description of change - Upstream range: [v1.46.3, 1.47.1) - Port commit: - MystenLabs/sui@343906c - MystenLabs/sui@1a496a5 - MystenLabs/sui@aec90b4 - MystenLabs/sui@24f9ea2 - Description: - Avoid std::thread::sleep() in safe_drop_db() - Add backoff to safe_drop_db - Mitigates the race between the destructor and metric threads. Reason: `rocksdb::DB::Destroy` returns an error immediately if any other reference is still alive - Reworks the 'rest-index' database to: - Add support for indexing information about epochs ## Links to any relevant issues None ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [x] Nodes (Validators and Full nodes): Add support for indexing epochs, object type information for transactions, type information for dynamic fields. Hint: This will trigger re-indexation of the REST indexes. --------- Co-authored-by: muXxer <git@muxxer.de>
…ialize_current_epoch`
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
f79ae9f to
edf9c4c
Compare
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
GetTransactionsin the gRPC API.GetEpochimplementation in gRPC #9233, feat(gRPC): addGetServiceInfoimplementation in gRPC #9314, feat(gRPC): addGetObjectsimplementation in gRPC #9328get_transactionssimtest by usingcargo simtest --package iota-e2e-tests --test grpc -- get_transactionsLinks to any relevant issues
Part of #8688
How the change has been tested
Release Notes
GetTransactionsin the gRPC API for internal usage.