Skip to content

Conversation

@bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Oct 28, 2025

Description of change

  • Initialize the gRPC proto files, which addressed APIs documented in Implement more endpoints in the internal gRPC interface #8688.
  • Note that the design of gRPC request/response in is that we focus on returning low-level BCS iota-type data, instead of extracting fields from the iota-type data and put them in response in most cases (to discuss).

Links to any relevant issues

Part of #8688

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin self-assigned this Oct 28, 2025
@bingyanglin bingyanglin added the node Issues related to the Core Node team label Oct 28, 2025
@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-backend Ignored Ignored Preview Nov 11, 2025 2:29pm
apps-ui-kit Ignored Ignored Preview Nov 11, 2025 2:29pm
iota-evm-bridge Ignored Ignored Preview Nov 11, 2025 2:29pm
iota-multisig-toolkit Ignored Ignored Preview Nov 11, 2025 2:29pm
rebased-explorer Ignored Ignored Preview Nov 11, 2025 2:29pm
wallet-dashboard Ignored Ignored Preview Nov 11, 2025 2:29pm

@bingyanglin bingyanglin force-pushed the feat/grpc-proto branch 3 times, most recently from f057b45 to 939d316 Compare October 28, 2025 10:58
@muXxer muXxer changed the base branch from develop to feat/grpc-implementation October 30, 2025 21:29
@muXxer muXxer changed the base branch from feat/grpc-implementation to feat/grpc-add-improved-tx-filter October 30, 2025 21:30
@muXxer muXxer changed the base branch from feat/grpc-add-improved-tx-filter to feat/grpc-implementation November 6, 2025 13:47
@muXxer muXxer force-pushed the feat/grpc-implementation branch 2 times, most recently from 2b239ac to 4b98630 Compare November 6, 2025 18:33
@muXxer muXxer force-pushed the feat/grpc-proto branch 4 times, most recently from 014d88b to 501e38d Compare November 11, 2025 14:12
@muXxer muXxer marked this pull request as ready for review November 11, 2025 14:12
@muXxer muXxer requested review from a team as code owners November 11, 2025 14:12
@muXxer
Copy link
Contributor

muXxer commented Nov 11, 2025

Failures in the grpc-server tests can be ignored. We will fix them in upcoming PRs.

@muXxer muXxer merged commit 57f340a into feat/grpc-implementation Nov 11, 2025
35 of 36 checks passed
@muXxer muXxer deleted the feat/grpc-proto branch November 11, 2025 15:23
muXxer added a commit that referenced this pull request Nov 17, 2025
# Description of change

- Initialize the gRPC proto files, which addressed APIs documented in
#8688.
- Note that the design of gRPC request/response in is that we focus on
returning low-level BCS iota-type data, instead of extracting fields
from the iota-type data and put them in response in most cases (to
discuss).

## Links to any relevant issues

Part of #8688

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have checked that new and existing unit tests pass locally with
my changes

---------

Co-authored-by: muXxer <git@muxxer.de>
muXxer added a commit that referenced this pull request Nov 19, 2025
# Description of change

- Initialize the gRPC proto files, which addressed APIs documented in
#8688.
- Note that the design of gRPC request/response in is that we focus on
returning low-level BCS iota-type data, instead of extracting fields
from the iota-type data and put them in response in most cases (to
discuss).

## Links to any relevant issues

Part of #8688

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have checked that new and existing unit tests pass locally with
my changes

---------

Co-authored-by: muXxer <git@muxxer.de>
muXxer added a commit that referenced this pull request Nov 20, 2025
# Description of change

- Initialize the gRPC proto files, which addressed APIs documented in
#8688.
- Note that the design of gRPC request/response in is that we focus on
returning low-level BCS iota-type data, instead of extracting fields
from the iota-type data and put them in response in most cases (to
discuss).

## Links to any relevant issues

Part of #8688

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have checked that new and existing unit tests pass locally with
my changes

---------

Co-authored-by: muXxer <git@muxxer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-protocol node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants