Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Linting #1417

Merged
merged 34 commits into from
Sep 2, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3d249d5
chore: Add linting and formatting to repo
maxwellmattryan Aug 18, 2021
5787abc
fix: Add quotemarks for GH Action syntax
maxwellmattryan Aug 18, 2021
74e7613
fix: Remove PR section from workflow
maxwellmattryan Aug 18, 2021
687a656
chore: Remove caching from linting CI and test Yarn cache
maxwellmattryan Aug 18, 2021
e68c29f
fix: Change config for CI
maxwellmattryan Aug 18, 2021
c246526
chore: Add all rules and prep for fixing
maxwellmattryan Aug 18, 2021
77736b0
chore: Add Husky pre-commit Git hook for formatting / linting
maxwellmattryan Aug 18, 2021
55e1a03
fix: Add Husky config to package.json (test)
maxwellmattryan Aug 18, 2021
0157041
fix: Add fix for Yarn and Git Bash on Windows 10
maxwellmattryan Aug 18, 2021
9abbd5d
chore: Re-format code with Prettier
maxwellmattryan Aug 18, 2021
e364058
chore: Add some more rules
maxwellmattryan Aug 18, 2021
3801a1a
chore: Remove package-based workflow
maxwellmattryan Aug 18, 2021
c2cd0de
fix: Change job step names
maxwellmattryan Aug 18, 2021
3478c43
chore: Adjust contribution guide
maxwellmattryan Aug 18, 2021
3eaf77a
fix: Change deadlink in contribution guide
maxwellmattryan Aug 18, 2021
d35ecaa
chore: Update yarn.lock
maxwellmattryan Aug 18, 2021
d623441
Merge branch 'develop' into branch 'chore/linting'
maxwellmattryan Aug 20, 2021
1238843
Merge branch 'develop'
maxwellmattryan Aug 31, 2021
8639de3
chore: Remove old CI and create new one
maxwellmattryan Aug 31, 2021
0da6c0e
chore: Change workflow job name
maxwellmattryan Aug 31, 2021
20f41a8
chore: Push formatting changes from Prettier
maxwellmattryan Aug 31, 2021
2ec181f
chore: Add rustfmt to linting CI
maxwellmattryan Aug 31, 2021
748d7b5
fix: Remove duplicate line in workflow
maxwellmattryan Aug 31, 2021
0f30585
fix: Add `-y` flag to CI command
maxwellmattryan Aug 31, 2021
521c892
fix: Move flag elsewhere
maxwellmattryan Aug 31, 2021
147512f
fix: Add `rustfmt` installation in CI
maxwellmattryan Aug 31, 2021
b2f824e
fix: Fix rustfmt
maxwellmattryan Aug 31, 2021
7de9f56
fix: Switch command order
maxwellmattryan Aug 31, 2021
d20767d
chore: Adjust yarn scripts in `package.json`
maxwellmattryan Aug 31, 2021
9f5383e
chore: Replace Rust setup in workflow
maxwellmattryan Sep 2, 2021
afacbfd
fix: Use proper rustfmt check in CI
maxwellmattryan Sep 2, 2021
7e1c40b
chore: Remove rustfmt from package.json scripts
maxwellmattryan Sep 2, 2021
80f4c62
fix: Fix syntax in workflow yml
maxwellmattryan Sep 2, 2021
257f4e8
fix: Resolve merge conflict for contribution guide
maxwellmattryan Sep 2, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Add Husky pre-commit Git hook for formatting / linting
  • Loading branch information
maxwellmattryan committed Aug 18, 2021
commit 77736b0a52d504309902e6436d674c3bc9ae629b
4 changes: 4 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn pre-commit
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
"lint:desktop": "eslint packages/desktop",
"lint:mobile": "eslint packages/mobile",
"lint:shared": "eslint packages/shared",
"postinstall": "patch-package"
"postinstall": "patch-package",
"pre-commit": "yarn format-check && yarn lint",
"prepare": "husky install"
},
"resolutions": {
"lodash": ">=4.17.21"
Expand Down