-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Linting #1417
chore: Linting #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
into branch 'chore/linting'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding rustfmt! Just a few suggestions
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Description of change
yarn lint
andyarn format[-check]
)rustfmt
for linting*.rs
filesdevelop
.github/CONTRIBUTING.md
with new linting step and updating CI linkyarn format
in root dir (NOTE: linting errors are everywhere so they will be in a separate PR)NOTE:
.svelte
files do not mix well with Prettier for some reason, so they are omitted. It is mainly just.ts
files that have the formatting.Links to any relevant issues
None
Type of change
How the change has been tested
Tested on:
Change checklist