Skip to content

Theme color & few other things #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2017
Merged

Theme color & few other things #11

merged 4 commits into from
Aug 27, 2017

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Aug 26, 2017

  • Add the possibility to use ThemeColor in decorations instead of hardcoded colors
  • Add a few other details around decorations (DecorationRangeBehavior )
  • Use a better type for Promise.all
  • Pin Fable to 0.6.x (Otherwise it get 0.7 from npm and the signature for exec is different)

Regarding the last one, would you be opposed to an update to Fable 1.x ? I suspect it's not easy but I've hit some bugs that I believe are fixed now.

@vbfox vbfox mentioned this pull request Aug 26, 2017
6 tasks
@Krzysztof-Cieslak Krzysztof-Cieslak merged commit c0bc138 into ionide:master Aug 27, 2017
@Krzysztof-Cieslak
Copy link
Member

Updating to Fable 1.0 would be welcome, I just don't have time for it, and I guess it could be quite a huge effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants