fix(card-header): reverse order of title and subtitle on ios

[brandyscarney]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Card header displays the title & subtitle in the order they are placed in the DOM

Issue URL: N/A

This was brought up while implementing the card documentation here: ionic-team/ionic-docs#2584 (comment)

What is the new behavior?

Card header changes the display to flex and reverses the order for the title & subtitle on ios mode.

Does this introduce a breaking change?

• Yes
• No
• Maybe

Unknown. This may be considered a breaking change if users are adding any other elements into the ion-card-header or if they are already changing the order to account for iOS. If they are leaving it as title -> subtitle then this would be a fix to get it closer to native.

Looking through the card api documentation it looks like we were showing them usage with the order reversed, likely for iOS but this would've been wrong for Material Design.

The kitchen sink demo (source code) also showed subtitle before title, making it wrong for Material Design.

Other information

I believe this needs some discussion before implementing it.

[sean-perkins]

Personally, I think we should treat this as a breaking change and target for v7. While it doesn't change public APIs, it does change the default style representation for iOS.

We have been considering other misc. spec alignment/design clean-up tasks as v7 as well, for similar reasons.

All this being said - I agree with the changes. I do think we need new screenshot tests captured for this change though.

[averyjohnston]

I agree with this change, and also that we should target v7 instead. Holding on review until tests pass though; you may need to run the screenshot update job.

[liamdebeasi]

Ditto to making this a v7 change.

[sean-perkins]

It looks like feature-7.0 is quite behind main currently. Quickly changing the base branch leads to a handful of merge conflicts as 400+ files tracked for changes.

We will either need to update feature.7.0 first, or cherry pick these changes off and apply them on a branch from feature-7.0.