Skip to content

Commit 2080890

Browse files
fix(card-header): reverse order of title and subtitle on ios (#26084)
BREAKING CHANGE: - The card header has ben changed to a flex container with direction set to `column` (top to bottom). In `ios` mode the direction is set to `column-reverse` which results in the subtitle displaying on top of the title.
1 parent 375c180 commit 2080890

18 files changed

+31
-15
lines changed

BREAKING.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ This is a comprehensive list of the breaking changes introduced in the major ver
1515
- [Browser and Platform Support](#version-7x-browser-platform-support)
1616
- [Components](#version-7x-components)
1717
- [Accordion Group](#version-7x-accordion-group)
18+
- [Card Header](#version-7x-card-header)
1819
- [Checkbox](#version-7x-checkbox)
1920
- [Datetime](#version-7x-datetime)
2021
- [Input](#version-7x-input)
@@ -69,6 +70,10 @@ This section details the desktop browser, JavaScript framework, and mobile platf
6970

7071
- Accordion Group no longer automatically adjusts the `value` property when passed an array and `multiple="false"`. Developers should update their apps to ensure they are using the API correctly.
7172

73+
<h4 id="version-7x-card-header">Card Header</h4>
74+
75+
- The card header has ben changed to a flex container with direction set to `column` (top to bottom). In `ios` mode the direction is set to `column-reverse` which results in the subtitle displaying on top of the title.
76+
7277
<h4 id="version-7x-checkbox">Checkbox</h4>
7378

7479
`ionChange` is no longer emitted when the `checked` property of `ion-checkbox` is modified externally. `ionChange` is only emitted from user committed changes, such as clicking or tapping the checkbox.
@@ -94,7 +99,7 @@ This section details the desktop browser, JavaScript framework, and mobile platf
9499

95100
<h4 id="version-7x-overlays">Overlays</h4>
96101

97-
Ionic now listens on the `keydown` event instead of the `keyup` event when determining when to dismiss overlays via the "Escape" key. Any applications that were listening on `keyup` to suppress this behavior should listen on `keydown` instead.
102+
Ionic now listens on the `keydown` event instead of the `keyup` event when determining when to dismiss overlays via the "Escape" key. Any applications that were listening on `keyup` to suppress this behavior should listen on `keydown` instead.
98103

99104
<h4 id="version-7x-range">Range</h4>
100105

@@ -130,7 +135,7 @@ iOS:
130135

131136
- The type signature of `value` supports `string | undefined`. Previously the type signature was `string | null | undefined`.
132137
- Developers needing to clear the checked segment item should assign a value of `''` instead of `null`.
133-
138+
134139
<h4 id="version-7x-select">Select</h4>
135140

136141
- `ionChange` is no longer emitted when the `value` of `ion-select` is modified externally. `ionChange` is only emitted from user committed changes, such as confirming a selected option in the select's overlay.
@@ -488,7 +493,7 @@ Developers must now provide an `ion-router-outlet` inside of `ion-tabs`. Previou
488493
<script>
489494
import { IonTabs, IonTabBar } from '@ionic/vue';
490495
import { defineComponent } from 'vue';
491-
496+
492497
export default defineComponent({
493498
components: { IonTabs, IonTabBar }
494499
});
@@ -507,7 +512,7 @@ Developers must now provide an `ion-router-outlet` inside of `ion-tabs`. Previou
507512
<script>
508513
import { IonTabs, IonTabBar, IonRouterOutlet } from '@ionic/vue';
509514
import { defineComponent } from 'vue';
510-
515+
511516
export default defineComponent({
512517
components: { IonTabs, IonTabBar, IonRouterOutlet }
513518
});

core/src/components/card-header/card-header.ios.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@
66

77
:host {
88
@include padding($card-ios-header-padding-top, $card-ios-header-padding-end, $card-ios-header-padding-bottom, $card-ios-header-padding-start);
9+
10+
flex-direction: column-reverse;
911
}
1012

1113
@supports (backdrop-filter: blur(0)) {
1214
:host(.card-header-translucent) {
1315
background-color: $card-ios-header-translucent-background-color;
1416
backdrop-filter: $card-ios-header-translucent-filter;
1517
}
16-
}
18+
}

core/src/components/card-header/card-header.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
--background: transparent;
88
--color: inherit;
99

10-
display: block;
10+
display: flex;
1111
position: relative;
1212

13+
flex-direction: column;
14+
1315
background: var(--background);
1416
color: var(--color);
1517
}
-118 Bytes
Loading
-22 Bytes
Loading
349 Bytes
Loading
-80 Bytes
Loading
16 Bytes
Loading
197 Bytes
Loading
853 Bytes
Loading

0 commit comments

Comments
 (0)