Skip to content

feat(ui): debounce persistence instead of throttle #8410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

feat(ui): debounce persistence instead of throttle #8410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions invokeai/frontend/web/src/app/components/InvokeAIUI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ interface Props extends PropsWithChildren {
* If provided, overrides in-app navigation to the model manager
*/
onClickGoToModelManager?: () => void;
storagePersistThrottle?: number;
storagePersistDebounce?: number;
}

const InvokeAIUI = ({
Expand All @@ -98,7 +98,7 @@ const InvokeAIUI = ({
loggingOverrides,
onClickGoToModelManager,
whatsNew,
storagePersistThrottle = 2000,
storagePersistDebounce = 2000,
}: Props) => {
const [store, setStore] = useState<ReturnType<typeof createStore> | undefined>(undefined);
const [didRehydrate, setDidRehydrate] = useState(false);
Expand Down Expand Up @@ -318,7 +318,7 @@ const InvokeAIUI = ({
const onRehydrated = () => {
setDidRehydrate(true);
};
const store = createStore({ persist: true, persistThrottle: storagePersistThrottle, onRehydrated });
const store = createStore({ persist: true, persistDebounce: storagePersistDebounce, onRehydrated });
setStore(store);
$store.set(store);
if (import.meta.env.MODE === 'development') {
Expand All @@ -333,7 +333,7 @@ const InvokeAIUI = ({
window.$store = undefined;
}
};
}, [storagePersistThrottle]);
}, [storagePersistDebounce]);

if (!store || !didRehydrate) {
return <Loading />;
Expand Down
4 changes: 2 additions & 2 deletions invokeai/frontend/web/src/app/store/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ const PERSISTED_KEYS = Object.values(SLICE_CONFIGS)
.filter((sliceConfig) => !!sliceConfig.persistConfig)
.map((sliceConfig) => sliceConfig.slice.reducerPath);

export const createStore = (options?: { persist?: boolean; persistThrottle?: number; onRehydrated?: () => void }) => {
export const createStore = (options?: { persist?: boolean; persistDebounce?: number; onRehydrated?: () => void }) => {
const store = configureStore({
reducer: rememberedRootReducer,
middleware: (getDefaultMiddleware) =>
Expand All @@ -204,7 +204,7 @@ export const createStore = (options?: { persist?: boolean; persistThrottle?: num
if (options?.persist) {
return enhancers.prepend(
rememberEnhancer(reduxRememberDriver, PERSISTED_KEYS, {
persistThrottle: options?.persistThrottle ?? 2000,
persistDebounce: options?.persistDebounce ?? 2000,
serialize,
unserialize,
prefix: '',
Expand Down